mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Renaud Barbier <renaud.barbier@ge.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RESEND PATCH] ppc: P2020RDB: add environment partition support
Date: Wed, 02 Apr 2014 16:01:43 +0100	[thread overview]
Message-ID: <533C2657.7040500@ge.com> (raw)
In-Reply-To: <20140402143500.GA25539@omega.Speedport_W_921V_1_24_000>

On 02/04/2014 15:35, Alexander Aring wrote:
>> -
>> > +	devfs_add_partition("nor0", 0xf60000, 0x8000, DEVFS_PARTITION_FIXED,
>> > +			"env0");
>> > +	devfs_add_partition("nor0", 0xf80000, 0x80000, DEVFS_PARTITION_FIXED,
>> > +			"self0");
> I think this should be:
> 
> 	devfs_add_partition("nor0", 0xf60000, SZ_512K, DEVFS_PARTITION_FIXED,
> 			"self0");
> 	devfs_add_partition("nor0", 0xf60000 + SZ_512K, SZ_32K, DEVFS_PARTITION_FIXED,
> 			"env0");
> 
> or your version is still correct? Or why you placed the env before self0 with a
> little room there?


The reset vector on this PPC architecture is at the top of the memory
range (0xfffffffc) so the barebox area should be at the top of the flash.

The flash sectors are 128KB so I placed the environment at the start of
previous sector. It is indeed a lots of space lost for environment.





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-04-02 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 14:18 Renaud Barbier
2014-04-02 14:35 ` Alexander Aring
2014-04-02 15:01   ` Renaud Barbier [this message]
2014-04-03  5:54 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533C2657.7040500@ge.com \
    --to=renaud.barbier@ge.com \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox