From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Holger Schurig <holgerschurig@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH] commands: rename "gpiolib" -> "gpioinfo"
Date: Thu, 15 May 2014 11:20:27 +0200 [thread overview]
Message-ID: <537486DB.9010302@gmail.com> (raw)
In-Reply-To: <1400144937-6006-1-git-send-email-holgerschurig@gmail.com>
On 05/15/2014 11:08 AM, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
Subject: rename "gpiolib" -> "gpioinfo"
How about joining the gpio related commands to "gpio"
and use e.g. -l for list?
Sebastian
> ---
> drivers/gpio/gpiolib.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 54ec5a6..611e41e 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -305,8 +305,6 @@ static int do_gpiolib(int argc, char *argv[])
> {
> int i;
>
> - printf("gpiolib: gpio lists\n");
> -
> for (i = 0; i < ARCH_NR_GPIOS; i++) {
> struct gpio_info *gi = &gpio_desc[i];
> int val = -1, dir = -1;
> @@ -316,7 +314,7 @@ static int do_gpiolib(int argc, char *argv[])
>
> /* print chip information and header on first gpio */
> if (gi->chip->base == i) {
> - printf("\ngpios %u-%u, chip %s:\n",
> + printf("\nGPIOs %u-%u, chip %s:\n",
> gi->chip->base,
> gi->chip->base + gi->chip->ngpio - 1,
> gi->chip->dev->name);
> @@ -330,7 +328,7 @@ static int do_gpiolib(int argc, char *argv[])
> val = gi->chip->ops->get(gi->chip,
> i - gi->chip->base);
>
> - printf(" gpio %*d: %*s %*s %*s %s\n", 4, i,
> + printf(" GPIO %*d: %*s %*s %*s %s\n", 4, i,
> 3, (dir < 0) ? "unk" : ((dir == GPIOF_DIR_IN) ? "in" : "out"),
> 3, (val < 0) ? "unk" : ((val == 0) ? "lo" : "hi"),
> 9, gi->requested ? "true" : "false",
> @@ -340,7 +338,7 @@ static int do_gpiolib(int argc, char *argv[])
> return 0;
> }
>
> -BAREBOX_CMD_START(gpiolib)
> +BAREBOX_CMD_START(gpioinfo)
> .cmd = do_gpiolib,
> BAREBOX_CMD_DESC("list registered GPIOs")
> BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-15 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 9:08 Holger Schurig
2014-05-15 9:08 ` [PATCH] magicvars: can now also list values Holger Schurig
2014-05-15 9:08 ` Holger Schurig
2014-05-15 9:20 ` Sebastian Hesselbarth [this message]
2014-05-15 9:49 ` [PATCH] commands: rename "gpiolib" -> "gpioinfo" Holger Schurig
2014-05-15 12:40 ` Sascha Hauer
2014-05-15 12:52 ` Sebastian Hesselbarth
2014-05-15 13:01 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537486DB.9010302@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox