mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] pinctrl: mvebu: add pinctrl drivers for Dove and Kirkwood
Date: Wed, 25 Jun 2014 09:35:32 +0200	[thread overview]
Message-ID: <53AA7BC4.5040301@gmail.com> (raw)
In-Reply-To: <20140625065615.GM15686@pengutronix.de>

On 06/25/2014 08:56 AM, Sascha Hauer wrote:
> On Tue, Jun 24, 2014 at 12:43:48PM +0200, Sebastian Hesselbarth wrote:
>> This adds pinctrl drivers for Marvell Dove and Kirkwood SoCs based
>> on a common driver stub. This design is based on the corresponding
>> Linux driver and should ease additional drivers for Marvell Armada
>> SoCs.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> Applied with a small change:
>
>> +static int kirkwood_pinctrl_probe(struct device_d *dev)
>> +{
>> +	const struct of_device_id *match =
>> +		of_match_node(kirkwood_pinctrl_of_match, dev->device_node);
>> +	struct mvebu_pinctrl_soc_info *soc =
>> +		(struct mvebu_pinctrl_soc_info *)match->data;
>> +
>> +	mpp_base = dev_request_mem_region(dev, 0);
>
> I added a return value check here. Not checking it means that the driver
> could do NULL pointer dereferences during runtime.
>
> I should really fix the places where the check is missing in the tree.

Ok, thanks for catching it. Did you also apply the same fix
to Dove's pinctrl stub?

Sebastian


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-06-25  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 10:43 Sebastian Hesselbarth
2014-06-25  6:56 ` Sascha Hauer
2014-06-25  7:35   ` Sebastian Hesselbarth [this message]
2014-06-25 12:40   ` Alexander Aring
2014-06-26  5:56     ` Sascha Hauer
2014-06-26 14:38       ` Alexander Aring
2014-06-26 19:01         ` Sascha Hauer
2014-06-25 13:52   ` [PATCH FIXUP] pinctrl: mvebu: fixup mpp_base check Sebastian Hesselbarth
2014-06-26  5:58     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AA7BC4.5040301@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox