From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH 5/6] USB: host: add xHCI HCD, Hub, and platform driver
Date: Thu, 24 Jul 2014 15:46:37 +0200 [thread overview]
Message-ID: <53D10E3D.1030908@gmail.com> (raw)
In-Reply-To: <1406208526-24261-6-git-send-email-sebastian.hesselbarth@gmail.com>
On 07/24/2014 03:28 PM, Sebastian Hesselbarth wrote:
> This adds support for xHCI USB 3.0 host controllers found on various
> SoCs and PCI devices. Currently, the driver only supports the virtual
> USB 2.0 ports of the host controller, so if you plan to use USB 3.0
> devices, put a USB 2.0 cable in between.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
[...]
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> new file mode 100644
> index 000000000000..64d39dd53e5a
> --- /dev/null
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -0,0 +1,699 @@
[...]
> +static void xhci_setup_common_hub_descriptor(struct xhci_hcd *xhci,
> + struct usb_hub_descriptor *desc, int ports)
> +{
> + u16 val;
> +
> + /* xhci section 5.4.9 says 20ms max */
> + desc->bPwrOn2PwrGood = 10;
> + desc->bHubContrCurrent = 0;
> +
> +// desc->bNbrPorts = ports;
> + desc->bNbrPorts = xhci->num_usb3_ports + xhci->num_usb2_ports;
Dammit. The commented line is correct, the one below is a left-over
from USB 3.0 testing.
Either fix it up or request a v2 please.
Sebastian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-24 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 13:28 [PATCH 0/6] Minor USB fixes and xHCI driver Sebastian Hesselbarth
2014-07-24 13:28 ` [PATCH 1/6] USB: Fix stale usb devices in usb_device_list Sebastian Hesselbarth
2014-07-24 16:09 ` Sebastian Hesselbarth
2014-07-24 18:51 ` Sebastian Hesselbarth
2014-07-24 13:28 ` [PATCH 2/6] USB: Count detected USB devices independent of dev_index Sebastian Hesselbarth
2014-07-24 13:28 ` [PATCH 3/6] USB: EHCI: use min3 from Linux Sebastian Hesselbarth
2014-07-24 13:28 ` [PATCH 4/6] include: import {lower,upper}_32_bits helpers Sebastian Hesselbarth
2014-07-24 13:28 ` [PATCH 5/6] USB: host: add xHCI HCD, Hub, and platform driver Sebastian Hesselbarth
2014-07-24 13:46 ` Sebastian Hesselbarth [this message]
2014-07-24 13:28 ` [PATCH 6/6] USB: host: add xHCI PCI driver Sebastian Hesselbarth
2014-07-24 19:11 ` [PATCH 0/6] Minor USB fixes and xHCI driver Sebastian Hesselbarth
2014-07-25 7:32 ` Sascha Hauer
2014-07-25 14:40 ` Sebastian Hesselbarth
2014-07-25 15:34 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D10E3D.1030908@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox