* Logical partition on barebox
@ 2014-12-10 16:21 Victorien Vedrine
2014-12-11 7:04 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Victorien Vedrine @ 2014-12-10 16:21 UTC (permalink / raw)
To: barebox
Hi,
I'm developping a board with barebox and Linux. For my application, I
need 5 partition on my SD card (3 primary and 2 logical).
On barebox prompt, I just see the 3 primary partitions (/dev/disk0.0,
/dev/disk0.1, /dev/disk0.2) and 1 extended partition (/dev/disk0.3). Is
there a way to see the 2 logical partitions ?
Best regards
Victorien
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Logical partition on barebox
2014-12-10 16:21 Logical partition on barebox Victorien Vedrine
@ 2014-12-11 7:04 ` Sascha Hauer
2014-12-11 10:44 ` Victorien Vedrine
[not found] ` <54895E46.5040109@ophrys.net>
0 siblings, 2 replies; 6+ messages in thread
From: Sascha Hauer @ 2014-12-11 7:04 UTC (permalink / raw)
To: Victorien Vedrine; +Cc: barebox
Hi Victorien,
On Wed, Dec 10, 2014 at 05:21:09PM +0100, Victorien Vedrine wrote:
> Hi,
> I'm developping a board with barebox and Linux. For my application,
> I need 5 partition on my SD card (3 primary and 2 logical).
> On barebox prompt, I just see the 3 primary partitions
> (/dev/disk0.0, /dev/disk0.1, /dev/disk0.2) and 1 extended partition
> (/dev/disk0.3). Is there a way to see the 2 logical partitions ?
Which barebox version do you use?
barebox supports extended partitions since:
| commit 6fecd2aaca209884a0ec1f58ccc42b91d1d4b828
| Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| Date: Fri Nov 8 11:13:41 2013 +0100
|
| partitions: dos: parse extended partition
|
| DOS MBRs might contain an extended partition that holds several logical
| partitions. Add these to the partitions of the block device.
|
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
If your version is newer then this seems to be a bug.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Logical partition on barebox
2014-12-11 7:04 ` Sascha Hauer
@ 2014-12-11 10:44 ` Victorien Vedrine
[not found] ` <54895E46.5040109@ophrys.net>
1 sibling, 0 replies; 6+ messages in thread
From: Victorien Vedrine @ 2014-12-11 10:44 UTC (permalink / raw)
To: barebox
Thanks for your answer.
In a first time, I used a barebox version with the last update at the
10/16/2013. I Found the patch which you are talking about and I update
barebox to the version of yesterday and I have the same problem.
The partitions of my SD card are this one (with fdisk) :
Périphérique Amorçage Début Fin Blocs Id. Système
/dev/sdg1 2048 6143 2048 53 OnTrack DM6 Aux3
/dev/sdg2 6144 10239 2048 10 OPUS
/dev/sdg3 10240 43007 16384 6 FAT16
/dev/sdg4 43008 15556607 7756800 5 Étendue
/dev/sdg5 43040 567327 262144 83 Linux
/dev/sdg6 567360 15556607 7494624 b W95 FAT32
I use an iMX28 processor and I have this line on device_init fonction to
add the SD card :
add_generic_device("mxs_mci", 0, NULL, IMX_SSP0_BASE, 0x2000,
IORESOURCE_MEM, &mci_pdata);
Is there any tests that I can do to find a solution or more informations
for a bug ?
Best regards
Victorien
Le 11/12/2014 08:04, Sascha Hauer a écrit :
> Hi Victorien,
>
> On Wed, Dec 10, 2014 at 05:21:09PM +0100, Victorien Vedrine wrote:
>> Hi,
>> I'm developping a board with barebox and Linux. For my application,
>> I need 5 partition on my SD card (3 primary and 2 logical).
>> On barebox prompt, I just see the 3 primary partitions
>> (/dev/disk0.0, /dev/disk0.1, /dev/disk0.2) and 1 extended partition
>> (/dev/disk0.3). Is there a way to see the 2 logical partitions ?
> Which barebox version do you use?
>
> barebox supports extended partitions since:
>
> | commit 6fecd2aaca209884a0ec1f58ccc42b91d1d4b828
> | Author: Uwe Kleine-König<u.kleine-koenig@pengutronix.de>
> | Date: Fri Nov 8 11:13:41 2013 +0100
> |
> | partitions: dos: parse extended partition
> |
> | DOS MBRs might contain an extended partition that holds several logical
> | partitions. Add these to the partitions of the block device.
> |
> | Signed-off-by: Uwe Kleine-König<u.kleine-koenig@pengutronix.de>
> | Signed-off-by: Sascha Hauer<s.hauer@pengutronix.de>
>
> If your version is newer then this seems to be a bug.
>
> Sascha
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Logical partition on barebox
[not found] ` <54895E46.5040109@ophrys.net>
@ 2014-12-11 11:32 ` Sascha Hauer
2014-12-11 12:06 ` Victorien Vedrine
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2014-12-11 11:32 UTC (permalink / raw)
To: Victorien Vedrine; +Cc: barebox
On Thu, Dec 11, 2014 at 10:05:10AM +0100, Victorien Vedrine wrote:
> Thanks for your answer.
> In a first time, I used a barebox version with the last update at the
> 10/16/2013. I Found the patch which you are talking about and I update
> barebox to the version of yesterday and I have the same problem.
> The partitions of my SD card are this one (with fdisk) :
>
> Périphérique Amorçage Début Fin Blocs Id. Système
> /dev/sdg1 2048 6143 2048 53 OnTrack DM6 Aux3
> /dev/sdg2 6144 10239 2048 10 OPUS
> /dev/sdg3 10240 43007 16384 6 FAT16
> /dev/sdg4 43008 15556607 7756800 5 Étendue
> /dev/sdg5 43040 567327 262144 83 Linux
> /dev/sdg6 567360 15556607 7494624 b W95 FAT32
>
> I use an iMX28 processor and I have this line on device_init fonction to
> add the SD card :
>
> add_generic_device("mxs_mci", 0, NULL, IMX_SSP0_BASE, 0x2000,
> IORESOURCE_MEM, &mci_pdata);
This is correct. If your card is shown then you made everything right
here.
>
> Is there any tests that I can do to find a solution or more informations
> for a bug ?
You could add a #define DEBUG on top of common/partitions/dos.c (above
the includes) and see if this gives more information. Otherwise you
can do some further debugging this file. Does dos_extended_partition()
get called?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Logical partition on barebox
2014-12-11 11:32 ` Sascha Hauer
@ 2014-12-11 12:06 ` Victorien Vedrine
2014-12-15 9:38 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Victorien Vedrine @ 2014-12-11 12:06 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Thanks,
I debug common/partitions/dos.c and the problem is
"dos_extended_partition() is not executed. I found why :
On dos_partition function there is a test to know the type of partition
(line 212). The comment says "partition type 0x05 or 0x0f can be
extended and just 0x0f is tested. The type extended partition on my SD
card is 0x05 and then it doesn't work.
I modify the source code of common/partitions/dos.c with
if ((pentry.dos_partition_type ==
0x0f)||(pentry.dos_partition_type == 0x05)) {
and now it's work.
Victorien
Le 11/12/2014 12:32, Sascha Hauer a écrit :
> On Thu, Dec 11, 2014 at 10:05:10AM +0100, Victorien Vedrine wrote:
>> Thanks for your answer.
>> In a first time, I used a barebox version with the last update at the
>> 10/16/2013. I Found the patch which you are talking about and I update
>> barebox to the version of yesterday and I have the same problem.
>> The partitions of my SD card are this one (with fdisk) :
>>
>> Périphérique Amorçage Début Fin Blocs Id. Système
>> /dev/sdg1 2048 6143 2048 53 OnTrack DM6 Aux3
>> /dev/sdg2 6144 10239 2048 10 OPUS
>> /dev/sdg3 10240 43007 16384 6 FAT16
>> /dev/sdg4 43008 15556607 7756800 5 Étendue
>> /dev/sdg5 43040 567327 262144 83 Linux
>> /dev/sdg6 567360 15556607 7494624 b W95 FAT32
>>
>> I use an iMX28 processor and I have this line on device_init fonction to
>> add the SD card :
>>
>> add_generic_device("mxs_mci", 0, NULL, IMX_SSP0_BASE, 0x2000,
>> IORESOURCE_MEM, &mci_pdata);
> This is correct. If your card is shown then you made everything right
> here.
>
>> Is there any tests that I can do to find a solution or more informations
>> for a bug ?
> You could add a #define DEBUG on top of common/partitions/dos.c (above
> the includes) and see if this gives more information. Otherwise you
> can do some further debugging this file. Does dos_extended_partition()
> get called?
>
> Sascha
>
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Logical partition on barebox
2014-12-11 12:06 ` Victorien Vedrine
@ 2014-12-15 9:38 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2014-12-15 9:38 UTC (permalink / raw)
To: Victorien Vedrine; +Cc: barebox
On Thu, Dec 11, 2014 at 01:06:18PM +0100, Victorien Vedrine wrote:
> Thanks,
>
> I debug common/partitions/dos.c and the problem is
> "dos_extended_partition() is not executed. I found why :
> On dos_partition function there is a test to know the type of
> partition (line 212). The comment says "partition type 0x05 or 0x0f
> can be extended and just 0x0f is tested. The type extended partition
> on my SD card is 0x05 and then it doesn't work.
> I modify the source code of common/partitions/dos.c with
> if ((pentry.dos_partition_type ==
> 0x0f)||(pentry.dos_partition_type == 0x05)) {
> and now it's work.
Nice. Care to send a patch to fix this upstream?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-15 9:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-10 16:21 Logical partition on barebox Victorien Vedrine
2014-12-11 7:04 ` Sascha Hauer
2014-12-11 10:44 ` Victorien Vedrine
[not found] ` <54895E46.5040109@ophrys.net>
2014-12-11 11:32 ` Sascha Hauer
2014-12-11 12:06 ` Victorien Vedrine
2014-12-15 9:38 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox