Re: [PATCH 1/5] mci: cadence: fix typo and actually build

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 12/15/25 3:21 PM, Steffen Trumtrar wrote:
> All other Kconfig symbols use MCI_* instead of MMC_*. Fix that.
> Also, add the cadence-sdhci to the Makefile, so that the driver is build.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Can we enable this in one of the defconfigs for CI coverage at least?

Cheers,
Ahmad

> ---
>  drivers/mci/Kconfig  | 2 +-
>  drivers/mci/Makefile | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig
> index 6736e7421c..e7b8afb3b4 100644
> --- a/drivers/mci/Kconfig
> +++ b/drivers/mci/Kconfig
> @@ -259,7 +259,7 @@ config MCI_STM32_SDMMC2
>  	  If you have a board based on such a SoC and with a SD/MMC slot,
>  	  say Y or M here.
>  
> -config MMC_CADENCE_SDHCI
> +config MCI_CADENCE_SDHCI
>  	tristate "SDHCI support for the Cadence SD/SDIO/eMMC controller"
>  	select MCI_SDHCI
>  	help
> diff --git a/drivers/mci/Makefile b/drivers/mci/Makefile
> index f76059e7b5..6a3af532a0 100644
> --- a/drivers/mci/Makefile
> +++ b/drivers/mci/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_MCI_ATMEL)		+= atmel_mci.o atmel_mci_common.o
>  obj-$(CONFIG_MCI_ATMEL_SDHCI)	+= atmel-sdhci.o atmel-sdhci-common.o
>  obj-$(CONFIG_MCI_BCM283X)	+= mci-bcm2835.o
>  obj-$(CONFIG_MCI_BCM283X_SDHOST)	+= bcm2835-sdhost.o
> +obj-$(CONFIG_MCI_CADENCE_SDHCI) += cadence-sdhci.o
>  obj-$(CONFIG_MCI_DOVE)		+= dove-sdhci.o
>  pbl-$(CONFIG_MCI_ATMEL_PBL)	+= atmel_mci_pbl.o atmel_mci_common.o
>  pbl-$(CONFIG_MCI_ATMEL_SDHCI_PBL)	+= atmel-sdhci-pbl.o atmel-sdhci-common.o
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |