* [PATCH] partitions: dos: Fix support of extended partition type 0x05
@ 2014-12-17 16:09 victorien
2014-12-19 6:52 ` Sascha Hauer
2014-12-19 18:59 ` Uwe Kleine-König
0 siblings, 2 replies; 5+ messages in thread
From: victorien @ 2014-12-17 16:09 UTC (permalink / raw)
To: barebox
---
common/partitions/dos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/partitions/dos.c b/common/partitions/dos.c
index 37addfd..8a3c5c3 100644
--- a/common/partitions/dos.c
+++ b/common/partitions/dos.c
@@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
* here as this is the easiest to parse and common
* enough.
*/
- if (pentry.dos_partition_type == 0x0f) {
+ if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
if (!extended_partition)
extended_partition = &pd->parts[n];
else
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] partitions: dos: Fix support of extended partition type 0x05
2014-12-17 16:09 [PATCH] partitions: dos: Fix support of extended partition type 0x05 victorien
@ 2014-12-19 6:52 ` Sascha Hauer
2014-12-19 9:14 ` Victorien Vedrine
2014-12-19 18:59 ` Uwe Kleine-König
1 sibling, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2014-12-19 6:52 UTC (permalink / raw)
To: victorien; +Cc: barebox
Hi victorien,
This patch needs a:
Signed-off-by: Victorien Vedrine <victorien.vedrine@ophrys.net>
Line. Otherwise I can't take it.
Sascha
On Wed, Dec 17, 2014 at 05:09:57PM +0100, victorien wrote:
> ---
> common/partitions/dos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
> index 37addfd..8a3c5c3 100644
> --- a/common/partitions/dos.c
> +++ b/common/partitions/dos.c
> @@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
> * here as this is the easiest to parse and common
> * enough.
> */
> - if (pentry.dos_partition_type == 0x0f) {
> + if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
> if (!extended_partition)
> extended_partition = &pd->parts[n];
> else
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] partitions: dos: Fix support of extended partition type 0x05
2014-12-19 6:52 ` Sascha Hauer
@ 2014-12-19 9:14 ` Victorien Vedrine
0 siblings, 0 replies; 5+ messages in thread
From: Victorien Vedrine @ 2014-12-19 9:14 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Hi Sascha,
Sorry, I'm beginner. I'll send a new patch
Victorien
Le 19/12/2014 07:52, Sascha Hauer a écrit :
> Hi victorien,
>
> This patch needs a:
>
> Signed-off-by: Victorien Vedrine <victorien.vedrine@ophrys.net>
>
> Line. Otherwise I can't take it.
>
>
> Sascha
>
> On Wed, Dec 17, 2014 at 05:09:57PM +0100, victorien wrote:
>> ---
>> common/partitions/dos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
>> index 37addfd..8a3c5c3 100644
>> --- a/common/partitions/dos.c
>> +++ b/common/partitions/dos.c
>> @@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
>> * here as this is the easiest to parse and common
>> * enough.
>> */
>> - if (pentry.dos_partition_type == 0x0f) {
>> + if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
>> if (!extended_partition)
>> extended_partition = &pd->parts[n];
>> else
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] partitions: dos: Fix support of extended partition type 0x05
2014-12-17 16:09 [PATCH] partitions: dos: Fix support of extended partition type 0x05 victorien
2014-12-19 6:52 ` Sascha Hauer
@ 2014-12-19 18:59 ` Uwe Kleine-König
2014-12-22 8:50 ` Victorien Vedrine
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2014-12-19 18:59 UTC (permalink / raw)
To: victorien; +Cc: barebox
Hallo,
On Wed, Dec 17, 2014 at 05:09:57PM +0100, victorien wrote:
> ---
> common/partitions/dos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
> index 37addfd..8a3c5c3 100644
> --- a/common/partitions/dos.c
> +++ b/common/partitions/dos.c
> @@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
> * here as this is the easiest to parse and common
> * enough.
> */
> - if (pentry.dos_partition_type == 0x0f) {
> + if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
apart from what Sascha said, also add spaces around ||. Also break lines
at or before column 80 (with tabs accounting for 8 columns).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] partitions: dos: Fix support of extended partition type 0x05
2014-12-19 18:59 ` Uwe Kleine-König
@ 2014-12-22 8:50 ` Victorien Vedrine
0 siblings, 0 replies; 5+ messages in thread
From: Victorien Vedrine @ 2014-12-22 8:50 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: barebox
Hi,
Ok, I'll change that.
Best regards
Victorien
Le 19/12/2014 19:59, Uwe Kleine-König a écrit :
> Hallo,
>
> On Wed, Dec 17, 2014 at 05:09:57PM +0100, victorien wrote:
>> ---
>> common/partitions/dos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
>> index 37addfd..8a3c5c3 100644
>> --- a/common/partitions/dos.c
>> +++ b/common/partitions/dos.c
>> @@ -209,7 +209,7 @@ static void dos_partition(void *buf, struct block_device *blk,
>> * here as this is the easiest to parse and common
>> * enough.
>> */
>> - if (pentry.dos_partition_type == 0x0f) {
>> + if ((pentry.dos_partition_type == 0x0f)||(pentry.dos_partition_type == 0x05)) {
> apart from what Sascha said, also add spaces around ||. Also break lines
> at or before column 80 (with tabs accounting for 8 columns).
>
> Best regards
> Uwe
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-22 8:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 16:09 [PATCH] partitions: dos: Fix support of extended partition type 0x05 victorien
2014-12-19 6:52 ` Sascha Hauer
2014-12-19 9:14 ` Victorien Vedrine
2014-12-19 18:59 ` Uwe Kleine-König
2014-12-22 8:50 ` Victorien Vedrine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox