From: Wadim Egorov <w.egorov@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3: For next 2/2] ARM: am33xx: Add support for reset reason detection
Date: Thu, 12 Feb 2015 10:03:43 +0100 [thread overview]
Message-ID: <54DC6C6F.5020809@phytec.de> (raw)
In-Reply-To: <20150212083029.GP12209@pengutronix.de>
On 12.02.2015 09:30, Sascha Hauer wrote:
> On Wed, Feb 11, 2015 at 10:57:50AM +0100, Wadim Egorov wrote:
>> On 11.02.2015 08:39, Sascha Hauer wrote:
>>> On Tue, Feb 10, 2015 at 03:13:58PM +0100, Wadim Egorov wrote:
>>>> Also activate in defconfig.
>>>>
>>>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
>>>> + break;
>>>> + case (1 << 1):
>>>> + reset_source_set(RESET_RST);
>>>> + break;
>>>> + case (1 << 0):
>>>> + reset_source_set(RESET_POR);
>>>> + break;
>>>> + default:
>>>> + reset_source_set(RESET_UKWN);
>>>> + break;
>>>> + }
>>>> +
>>>> + return 0;
>>>> +}
>>>> +device_initcall(am33xx_detect_reset_reason);
>>> No SoC specific initcall without testing if you're running on the
>>> correct SoC please. Better call it from am33xx_init() which is only
>>> executed on am33xx.
>>>
>>> Sascha
>> Calling it from am33xx_init() was also my idea in the first place.
>> AFAIK you have to call reset_source_set() after coredevice_initcall().
>> So it is not possible to call it from am33xx_init().
> Could you try this patch? It shoud resolve this issue.
>
> Sascha
It works with your changes. I will send a v4 later.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-02-12 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 14:13 [PATCH v3: For next 1/2] reset_source: Add external reset Wadim Egorov
2015-02-10 14:13 ` [PATCH v3: For next 2/2] ARM: am33xx: Add support for reset reason detection Wadim Egorov
2015-02-11 7:39 ` Sascha Hauer
2015-02-11 9:57 ` Wadim Egorov
2015-02-12 8:30 ` Sascha Hauer
2015-02-12 9:03 ` Wadim Egorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC6C6F.5020809@phytec.de \
--to=w.egorov@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox