[PATCH] makfiles: add emacs syntax highlighting hint

[PATCH] makfiles: add emacs syntax highlighting hint

[Marc Kleine-Budde]

This patches makes a standard emacs to recognise the files as makefiles.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 images/Makefile.am33xx   | 3 ++-
 images/Makefile.imx      | 1 +
 images/Makefile.mvebu    | 1 +
 images/Makefile.mxs      | 1 +
 images/Makefile.rockchip | 1 +
 images/Makefile.tegra    | 1 +
 scripts/Makefile.lib     | 1 +
 7 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/images/Makefile.am33xx b/images/Makefile.am33xx
index 002c1038f812..fde8f3455974 100644
--- a/images/Makefile.am33xx
+++ b/images/Makefile.am33xx
@@ -1,4 +1,5 @@
-
+# -*-makefile-*-
+#
 # %.mlo - convert into mlo image
 # ----------------------------------------------------------------
 quiet_cmd_mlo_image = MLO     $@
diff --git a/images/Makefile.imx b/images/Makefile.imx
index f5f4cf3dd6e8..f05e45c8f4b4 100644
--- a/images/Makefile.imx
+++ b/images/Makefile.imx
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 #
 # barebox image generation Makefile for i.MX images
 #
diff --git a/images/Makefile.mvebu b/images/Makefile.mvebu
index 5e90855d2b7a..78cc25f08d7b 100644
--- a/images/Makefile.mvebu
+++ b/images/Makefile.mvebu
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 #
 # barebox image generation Makefile for Marvell mvebu
 #
diff --git a/images/Makefile.mxs b/images/Makefile.mxs
index 733f83bd1fe0..de8b74758433 100644
--- a/images/Makefile.mxs
+++ b/images/Makefile.mxs
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 #
 # barebox image generation Makefile for MXS images
 #
diff --git a/images/Makefile.rockchip b/images/Makefile.rockchip
index 24444330133e..3e42cee432d0 100644
--- a/images/Makefile.rockchip
+++ b/images/Makefile.rockchip
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 #
 # barebox image generation Makefile for Rockchip images
 #
diff --git a/images/Makefile.tegra b/images/Makefile.tegra
index 4f876e4b5969..281a83d8ce7d 100644
--- a/images/Makefile.tegra
+++ b/images/Makefile.tegra
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 #
 # barebox image generation Makefile for Tegra images
 #
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 57426d030285..f5a9450ba5c7 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -1,3 +1,4 @@
+# -*-makefile-*-
 # Backward compatibility - to be removed...
 extra-y	+= $(EXTRA_TARGETS)
 # Figure out what we need to build from the various variables
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Jean-Christophe PLAGNIOL-VILLARD]

On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
> This patches makes a standard emacs to recognise the files as makefiles.
not a fan of vi or emacs stuff in file

btw I plan to drop the images/ and move them back to the ARCH

Best Regads,
J.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  images/Makefile.am33xx   | 3 ++-
>  images/Makefile.imx      | 1 +
>  images/Makefile.mvebu    | 1 +
>  images/Makefile.mxs      | 1 +
>  images/Makefile.rockchip | 1 +
>  images/Makefile.tegra    | 1 +
>  scripts/Makefile.lib     | 1 +
>  7 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/images/Makefile.am33xx b/images/Makefile.am33xx
> index 002c1038f812..fde8f3455974 100644
> --- a/images/Makefile.am33xx
> +++ b/images/Makefile.am33xx
> @@ -1,4 +1,5 @@
> -
> +# -*-makefile-*-
> +#
>  # %.mlo - convert into mlo image
>  # ----------------------------------------------------------------
>  quiet_cmd_mlo_image = MLO     $@
> diff --git a/images/Makefile.imx b/images/Makefile.imx
> index f5f4cf3dd6e8..f05e45c8f4b4 100644
> --- a/images/Makefile.imx
> +++ b/images/Makefile.imx
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  #
>  # barebox image generation Makefile for i.MX images
>  #
> diff --git a/images/Makefile.mvebu b/images/Makefile.mvebu
> index 5e90855d2b7a..78cc25f08d7b 100644
> --- a/images/Makefile.mvebu
> +++ b/images/Makefile.mvebu
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  #
>  # barebox image generation Makefile for Marvell mvebu
>  #
> diff --git a/images/Makefile.mxs b/images/Makefile.mxs
> index 733f83bd1fe0..de8b74758433 100644
> --- a/images/Makefile.mxs
> +++ b/images/Makefile.mxs
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  #
>  # barebox image generation Makefile for MXS images
>  #
> diff --git a/images/Makefile.rockchip b/images/Makefile.rockchip
> index 24444330133e..3e42cee432d0 100644
> --- a/images/Makefile.rockchip
> +++ b/images/Makefile.rockchip
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  #
>  # barebox image generation Makefile for Rockchip images
>  #
> diff --git a/images/Makefile.tegra b/images/Makefile.tegra
> index 4f876e4b5969..281a83d8ce7d 100644
> --- a/images/Makefile.tegra
> +++ b/images/Makefile.tegra
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  #
>  # barebox image generation Makefile for Tegra images
>  #
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 57426d030285..f5a9450ba5c7 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -1,3 +1,4 @@
> +# -*-makefile-*-
>  # Backward compatibility - to be removed...
>  extra-y	+= $(EXTRA_TARGETS)
>  # Figure out what we need to build from the various variables
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 632 bytes --]

On 04/02/2015 10:35 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
>> This patches makes a standard emacs to recognise the files as makefiles.
> not a fan of vi or emacs stuff in file

admit, you don't like emacs :D

> btw I plan to drop the images/ and move them back to the ARCH

why?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1053 bytes --]

On 04/02/2015 10:53 AM, Marc Kleine-Budde wrote:
> On 04/02/2015 10:35 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
>>> This patches makes a standard emacs to recognise the files as makefiles.
>> not a fan of vi or emacs stuff in file
> 
> admit, you don't like emacs :D
> 
>> btw I plan to drop the images/ and move them back to the ARCH
> 
> why?

I don't care where it's located, but my images/Makefile.habv4
needs/can/should shared between mxs (mx28) and imx (mx6), once we add
mx28 support.

Orthogonal to moving the Makefiles from image/: what about moving the
SOC specific image generation rules from scripts/Makefile.lib into the
correct Makefile.<SOC> file (where ever that file lives)?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Jean-Christophe PLAGNIOL-VILLARD]

On 10:53 Thu 02 Apr     , Marc Kleine-Budde wrote:
> On 04/02/2015 10:35 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
> >> This patches makes a standard emacs to recognise the files as makefiles.
> > not a fan of vi or emacs stuff in file
> 
> admit, you don't like emacs :D

I don't like vi sutff in file too

and I do use vim

I also said fix your editor

otherwise we can eclipse, vim stuff too


> 
> > btw I plan to drop the images/ and move them back to the ARCH
> 
> why?
to be more clean

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

On 04/02/2015 11:26 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:53 Thu 02 Apr     , Marc Kleine-Budde wrote:
>> On 04/02/2015 10:35 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
>>>> This patches makes a standard emacs to recognise the files as makefiles.
>>> not a fan of vi or emacs stuff in file
>>
>> admit, you don't like emacs :D
> 
> I don't like vi sutff in file too
> and I do use vim
> I also said fix your editor
> otherwise we can eclipse, vim stuff too

I was trying to troll, but failed :)

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Lucas Stach]

Am Donnerstag, den 02.04.2015, 10:35 +0200 schrieb Jean-Christophe
PLAGNIOL-VILLARD:
> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
> > This patches makes a standard emacs to recognise the files as makefiles.
> not a fan of vi or emacs stuff in file
> 
> btw I plan to drop the images/ and move them back to the ARCH
> 
I'm not sure if this is time spent well.

Moving the generated images _again_ will get you into some serious
discussions with the people integrating barebox into BSP builds. We
finally settled for a single directory going forward and changing this
is not a good idea.

Or did you mean just moving the rules out of images/, but keeping the
generated binaries there? This might in fact be doable.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1208 bytes --]

On 04/02/2015 10:55 AM, Lucas Stach wrote:
> Am Donnerstag, den 02.04.2015, 10:35 +0200 schrieb Jean-Christophe
> PLAGNIOL-VILLARD:
>> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
>>> This patches makes a standard emacs to recognise the files as makefiles.
>> not a fan of vi or emacs stuff in file
>>
>> btw I plan to drop the images/ and move them back to the ARCH
>>
> I'm not sure if this is time spent well.
> 
> Moving the generated images _again_ will get you into some serious
> discussions with the people integrating barebox into BSP builds. We
> finally settled for a single directory going forward and changing this
> is not a good idea.

+1

> Or did you mean just moving the rules out of images/, but keeping the
> generated binaries there? This might in fact be doable.

On the first sight there's some marvell image related
doubling/copy-paste leftovers in ARCH and in images/.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Alexander Aring]

On Thu, Apr 02, 2015 at 10:59:41AM +0200, Marc Kleine-Budde wrote:
> On 04/02/2015 10:55 AM, Lucas Stach wrote:
> > Am Donnerstag, den 02.04.2015, 10:35 +0200 schrieb Jean-Christophe
> > PLAGNIOL-VILLARD:
> >> On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
> >>> This patches makes a standard emacs to recognise the files as makefiles.
> >> not a fan of vi or emacs stuff in file
> >>
> >> btw I plan to drop the images/ and move them back to the ARCH
> >>
> > I'm not sure if this is time spent well.
> > 
> > Moving the generated images _again_ will get you into some serious
> > discussions with the people integrating barebox into BSP builds. We
> > finally settled for a single directory going forward and changing this
> > is not a good idea.
> 
> +1
> 
> > Or did you mean just moving the rules out of images/, but keeping the
> > generated binaries there? This might in fact be doable.
> 
> On the first sight there's some marvell image related
> doubling/copy-paste leftovers in ARCH and in images/.
> 

reminds me to send patches for RPi build which doesn't place the barebox
image into "images/", otherwise I get a [0]. It's placed in root
directory of barebox "barebox.bin". :-)

- Alex

[0] https://www.mail-archive.com/ptxdist@pengutronix.de/msg09539.html

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] makfiles: add emacs syntax highlighting hint

[Jean-Christophe PLAGNIOL-VILLARD]

On 10:55 Thu 02 Apr     , Lucas Stach wrote:
> Am Donnerstag, den 02.04.2015, 10:35 +0200 schrieb Jean-Christophe
> PLAGNIOL-VILLARD:
> > On 00:33 Wed 01 Apr     , Marc Kleine-Budde wrote:
> > > This patches makes a standard emacs to recognise the files as makefiles.
> > not a fan of vi or emacs stuff in file
> > 
> > btw I plan to drop the images/ and move them back to the ARCH
> > 
> I'm not sure if this is time spent well.
> 
> Moving the generated images _again_ will get you into some serious
> discussions with the people integrating barebox into BSP builds. We
> finally settled for a single directory going forward and changing this
> is not a good idea.
> 
> Or did you mean just moving the rules out of images/, but keeping the
> generated binaries there? This might in fact be doable.
binary yes we must to do not break the build system

or a symlink at least

Best Regards,
J.
> 
> Regards,
> Lucas
> -- 
> Pengutronix e.K.             | Lucas Stach                 |
> Industrial Linux Solutions   | http://www.pengutronix.de/  |
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox