Re: [PATCH v2 2/2] ARM: i.MX7: add 96Boards Meerkat96 support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 11.07.22 16:12, Johannes Zink wrote:
> This is a i.MX7D-based board with an upstream device tree.
> Add the necessary boilerplate to have barebox create an image.
> 
> The memory settings are taken from U-Boot v2022.07-rc6.
> 
> System reset requires pmic driver which is not available yet in barebox.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
> v1 -> v2:
>  - added meerkat96 board to imx_v7_defconfig
>  - added Documentation for meerkat96 board
> ---
>  Documentation/boards/imx/meerkat96.rst        |  31 ++++++
>  arch/arm/boards/Makefile                      |   1 +
>  arch/arm/boards/meerkat96/Makefile            |   4 +
>  arch/arm/boards/meerkat96/board.c             |  10 ++
>  .../flash-header-mx7-meerkat96.imxcfg         | 105 ++++++++++++++++++
>  arch/arm/boards/meerkat96/lowlevel.c          |  34 ++++++
>  arch/arm/configs/imx_v7_defconfig             |   1 +
>  arch/arm/dts/Makefile                         |   1 +
>  arch/arm/dts/imx7d-meerkat96.dts              |  42 +++++++
>  arch/arm/mach-imx/Kconfig                     |   5 +
>  images/Makefile.imx                           |   5 +
>  11 files changed, 239 insertions(+)
>  create mode 100644 Documentation/boards/imx/meerkat96.rst
>  create mode 100644 arch/arm/boards/meerkat96/Makefile
>  create mode 100644 arch/arm/boards/meerkat96/board.c
>  create mode 100644 arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg
>  create mode 100644 arch/arm/boards/meerkat96/lowlevel.c
>  create mode 100644 arch/arm/dts/imx7d-meerkat96.dts
> 
> diff --git a/Documentation/boards/imx/meerkat96.rst b/Documentation/boards/imx/meerkat96.rst
> new file mode 100644
> index 000000000..3cdb1beaf
> --- /dev/null
> +++ b/Documentation/boards/imx/meerkat96.rst
> @@ -0,0 +1,31 @@
> +Meerkat 96
> +==========
> +
> +The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz and 512 MB DRAM. For further details on the board's features check the manufacturers page at https://www.96boards.org/product/imx7-96
> +
> +Serial console
> +--------------
> +
> +UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). If you use the UART-To-Serial-Converter provided with the board, you can just connect the Black jumper to B, the White to W and the Green to G. The UART uses 3.3V levels. 

Quite a long line. Could you break it?

> +
> +Building Barebox                                                        
> +----------------                                                        
> +                                                                        
> +To build Barebox for ZII i.MX7 based boards do the following:   

That's not a ZII.
        
> +                                                                        
> +.. code-block:: sh                                                      
> +           

Much trailing whitespace. Block copy? :^)

Sascha accepts fixup commits, so you can create a fixup locally
and

  git send-email -1 --in-reply-to="<20220711141246.3331160-2-j.zink@pengutronix.de>"

to have it appear correctly threaded.

Cheers,
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |