From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zli2U-0008S8-Qu for barebox@lists.infradead.org; Mon, 12 Oct 2015 18:41:39 +0000 Received: by wicgb1 with SMTP id gb1so159940925wic.1 for ; Mon, 12 Oct 2015 11:41:17 -0700 (PDT) Message-ID: <561BFECA.1010105@gmail.com> Date: Mon, 12 Oct 2015 20:41:14 +0200 From: Sebastian Hesselbarth References: <1444341979-19157-1-git-send-email-sebastian.hesselbarth@gmail.com> <87d1wk74nt.fsf@belgarion.home> In-Reply-To: <87d1wk74nt.fsf@belgarion.home> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 00/17] Armada 370/XP NAND driver To: Robert Jarzmik Cc: Thomas Petazzoni , barebox@lists.infradead.org, Ezequiel Garcia On 12.10.2015 12:38, Robert Jarzmik wrote: > Sebastian Hesselbarth writes: > >> This series is, of course, untested on mach-pxa and needs a >> Tested-by. I have tested the new driver on Armada XP based >> Lenovo ix4-300d and todays -next. > > I tested the parial serie patches : > * 7f109d9 (test-sebastian) mtd: nand_mrvl_nfc: Prepare for different HW ECC strengths > * 1b791e9 mtd: nand_mrvl_nfc: Fix num-cs property parsing > * 2b1b488 mtd: nand_mrvl_nfc: Use Auto Read Status on program/erase > * b198e62 mtd: nand_mrvl_nfc: Clear OOB data with 0xff instead of 0x00 > * 56e0cfd mtd: nand_mrvl_nfc: Remove keep_config > * 1a42d8e arm: pxa: Remove pxa_get_nandclk() > * bc3db6f mtd: nand: Clarify Marvell Orion Kconfig prompt > * 15577a6 mtd: nand_mrvl_nfc: Use common clock for core clock > * 40debf2 arm: pxa: Prepare for NAND clkdev lookup on PXA3xx > * ace2e99 (HEAD, tmp) net: netconsole: add puts > * 0b8212a (tag: v2015.10.0) Release v2015.10.0 > > As a result I have : > mrvl_nand mrvl_nand0: alloc nand resource failed > mrvl_nand mrvl_nand0: probe failed: No such file or directory > > This breaks zylonite support. Without the serie, the NAND works (ie. at "tmp" > branch"). Ok, this is clk_get() failing to find the NAND clock. I have reworked speed-3xx.c and Zylonite's board.c. AFAIKS, clk_register_clkdev() does not link the clock to the nfc device, therefore we have to use clkdev_add_physbase() in board.c. I have prepared a branch for you based on above v2015.10.0 to ease testing with all comments included so far: https://github.com/shesselba/barebox-dove.git testing/nfc-for-robert Thanks, Sebastian _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox