mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1
Date: Mon, 26 Oct 2015 07:09:07 -0700	[thread overview]
Message-ID: <562E3403.1020305@nelint.com> (raw)
In-Reply-To: <20151026065450.GT14476@pengutronix.de>

Hi Sascha,

On 10/25/2015 11:54 PM, Sascha Hauer wrote:
> On Fri, Oct 23, 2015 at 04:34:40PM -0700, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson <eric@nelint.com>
>> ---
>>  arch/arm/mach-imx/imx6-mmdc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks
> 
> Sascha
> 
>>
>> diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c
>> index 40fe0cf..7840c1a 100644
>> --- a/arch/arm/mach-imx/imx6-mmdc.c
>> +++ b/arch/arm/mach-imx/imx6-mmdc.c
>> @@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
>>  	writel(v, P0_IPS + MAPSR);
>>  
>>  	/* restore MDMISC value (RALAT, WALAT) */
>> -	writel(esdmisc_val, P1_IPS + MDMISC);
>> +	writel(esdmisc_val, P0_IPS + MDMISC);
>>  
>>  	/* clear DQS pull ups */
>>  	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
>> -- 
>> 2.6.2
>>
>>
> 

Note that this typo should have had an impact on performance
because RALAT and WALAT for MMDC0 would be left at their
max values.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-10-26 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 23:34 Eric Nelson
2015-10-26  6:54 ` Sascha Hauer
2015-10-26 14:09   ` Eric Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562E3403.1020305@nelint.com \
    --to=eric@nelint.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox