mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Dr.-Ing. Martin Däumler SYS TEC electronic GmbH" <martin.daeumler@systec-electronic.com>
To: barebox@lists.infradead.org
Cc: "Daniel Krüger" <daniel.krueger@systec-electronic.com>,
	"Alexander Stein" <alexander.stein@systec-electronic.com>
Subject: Crash after failed UBIFS mount
Date: Wed, 2 Mar 2016 10:24:43 +0100	[thread overview]
Message-ID: <56D6B15B.2040206@systec-electronic.com> (raw)

Hello,

we encountered a problem of barebox tag 2015.05.0, which is also 
reproducible with tag 2016.01.0. Mounting an UBIFS file system partition 
fails (correctly) and barebox crashes while cleaning up. The call 
hierarchy is
as follows:

-mount() (fs/fs.c:1243): try to mount ubifs partition; call 
register_device()
--register_device() (drivers/base/driver.c:138):
---match() (drivers/base/driver.c:117): look for a suitable device driver
----device_probe() (drivers/base/driver.c:82): ubifs partition fails to 
mount due to corrupted LEB
----device_probe(): delete device's 'active' list ('list_del(&dev->active)')
---match(): set device driver to NULL and return -1 to register_device()
--register_device(): return 0 (success) to mount()
-mount(): check device driver and call unregister_device() due to 
invalid driver
--unregister_device() (drivers/base/driver.c:180): delete device's 
'active' list the second time -> crash

Barebox does not crash if drivers/base/driver.c:92, i.e., list deletion 
in device_probe(), is removed. Is the removal of the list deletion a 
valid solution or does this have side effects?


With regards,
Martin Däumler

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2016-03-02  9:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02  9:24 Dr.-Ing. Martin Däumler SYS TEC electronic GmbH [this message]
2016-03-02 10:00 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D6B15B.2040206@systec-electronic.com \
    --to=martin.daeumler@systec-electronic.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=barebox@lists.infradead.org \
    --cc=daniel.krueger@systec-electronic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox