Re: [PATCH] Force set console baudrate

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On Jul 10, 2013, at 1:43 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:

> On Tue, Jul 09, 2013 at 09:22:10PM +0600, Alexey Galakhov wrote:
>> Most serial drivers require setbrg() to be called at least once. Call them
>> just after the device has been added.
>> 
>> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>

This is wrong if you do this at boot which means you force the same baudrate
on all the console

We must do this only is enable by default of via shell

and some console may not need the setbrg call back (keyboard or fbdev as example)

Also if we want to use a rs232 for controlling a mcu the baud rate may not be the
CONFIG_BAUDRATE

so force it at register is wrong

Best Regards,
J.
> 
> Applied, thanks.
> 
> Sascha
> 
>> ---
>> common/console.c |    1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/common/console.c b/common/console.c
>> index a0a06f6..abf5322 100644
>> --- a/common/console.c
>> +++ b/common/console.c
>> @@ -147,6 +147,7 @@ int console_register(struct console_device *newcdev)
>> 		newcdev->baudrate = CONFIG_BAUDRATE;
>> 		dev_add_param_int(dev, "baudrate", console_baudrate_set,
>> 			NULL, &newcdev->baudrate, "%u", newcdev);
>> +		newcdev->setbrg(newcdev, newcdev->baudrate);
>> 	}
>> 
>> 	dev_add_param(dev, "active", console_std_set, NULL, 0);
>> -- 
>> 1.7.10.4
>> 
>> 
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox