From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Johannes Schneider <johannes.schneider@leica-geosystems.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/1] ARM: i.MX8M: fix typo in function call
Date: Wed, 11 Jan 2023 11:20:29 +0100 [thread overview]
Message-ID: <600fb691-b7ce-bc5b-321a-6284534a3c9f@pengutronix.de> (raw)
In-Reply-To: <20230111100111.677018-2-johannes.schneider@leica-geosystems.com>
On 11.01.23 11:01, Johannes Schneider wrote:
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Please add commit messages. Even for seemingly trivial changes, there
is always something that can be explained, e.g.
"While both functions are equivalent, it looks out-of-place to use
the imx8mm_ variant in an i.MX8MN board's code and in future we may
elect to configure clocking differently on the i.MX8MP."
Which brings us to:
> - imx8mm_early_clock_init();
> + imx8mp_early_clock_init();
Did you compile-test this? There's no imx8mp_early_clock_init defined..
> imx8m_ccgr_clock_enable(IMX8M_CCM_CCGR_I2C1);
>
> i2c = imx8m_i2c_early_init(IOMEM(MX8MP_I2C1_BASE_ADDR));
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-01-11 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:01 [PATCH v2 1/1] ARM: i.MX8M: add PCA9450 PMIC on rev-b EVK Johannes Schneider
2023-01-11 10:01 ` [PATCH v2 1/1] ARM: i.MX8M: fix typo in function call Johannes Schneider
2023-01-11 10:20 ` Ahmad Fatoum [this message]
2023-01-11 10:01 ` [PATCH v2 1/1] ARM: i.MX8M: smccc: fix firmware_atf check Johannes Schneider
2023-01-11 10:21 ` Ahmad Fatoum
2023-01-11 10:17 ` [PATCH v2 1/1] ARM: i.MX8M: add PCA9450 PMIC on rev-b EVK Ahmad Fatoum
2023-01-11 10:26 ` Ahmad Fatoum
2023-01-19 8:59 ` Marco Felsch
2023-01-23 6:07 ` SCHNEIDER Johannes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600fb691-b7ce-bc5b-321a-6284534a3c9f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=johannes.schneider@leica-geosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox