From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] Revert "nand_base: detect more ONFI flash"
Date: Wed, 8 May 2013 15:30:24 +0800 [thread overview]
Message-ID: <6061FD58-D248-4A13-98E4-7AAD7A80CFCF@jcrosoft.com> (raw)
In-Reply-To: <20130508051106.GS32299@pengutronix.de>
On May 8, 2013, at 1:11 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Tue, May 07, 2013 at 10:21:39PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> this brake the nand support on at91sam9x5ek
>> where we have a non compliant ONFI nand
>> NAND device: Manufacturer ID: 0xad, Chip ID: 0xda (Hynix NAND 256MiB 3,3V 8-bit), 256MiB, page size: 2048, OOB size: 64
>>
>> This reverts commit 4c2bdc8728016b3412523e3264651651fe752860.
>
> Thank you for letting us know that this patch causes a regression for
> you. I this happens, please first try and fix the regression. If that
> doesn't work please tell us what about the original patch is so wrong
> that it needs to be reverted. With a good explanation it could be that
> someone else has an idea. And whatever you do, put the original author,
> Eric in this case, on Cc.
This commit was supposed just able to detect that a Nand is ONFI
but instead it brake supported Nand
So Eric can fix it but I've not time to debug this before 1 month
and the few platform that use ONFI are all busy
So as the commit just allow to detect a band is ONFI can we revert it
to keep non-ONFI Nand to work
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-05-08 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 20:21 Jean-Christophe PLAGNIOL-VILLARD
2013-05-08 5:11 ` Sascha Hauer
2013-05-08 7:30 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-05-08 16:25 ` Eric Bénard
2013-05-08 16:36 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-15 6:46 ` Re[2]: " Alexander Shiyan
2013-05-15 6:59 ` Sascha Hauer
2013-05-15 7:08 ` Re[2]: " Alexander Shiyan
2013-05-15 7:50 ` Re[3]: " Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6061FD58-D248-4A13-98E4-7AAD7A80CFCF@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox