Re: [PATCH v2 1/2] recursive_action: add ACTION_SORT flag

["Baeuerle, Florian" <Florian.Baeuerle@allegion.com>]

Hi Sascha,

thanks a lot!

There's two things I noticed when reviewing the patches:

The commit message of 47866ba5 is a bit misleading since poison.h is no longer
being added in the commit.

861ce6d looks a bit weird, I guess that's a typo (ACTION_SORT | ACTION_SORT). 


- Florian

Am Donnerstag, den 03.01.2019, 11:59 +0100 schrieb Sascha Hauer:
> Hi Florian,
> 
> On Wed, Dec 19, 2018 at 02:02:03PM +0000, Baeuerle, Florian wrote:
> > Add a flag to sort directory entries before recursing into them.
> > 
> > Since this part of lib/ is used inside barebox as well as in
> > scripts/bareboxenv.c, we cannot easily use stringlists from lib/, which
> > would have made the code a bit nicer.
> > 
> > Further, add poison.h from kernel 4.5-rc1, which was the base for
> > importing linux headers under scripts/ in a883d9a. This is required for
> > actually using kernel linked lists within scripts/ tools.
> 
> I applied this with some changes. It was important for me that the sort
> support does not leak into the barebox image so we do not increase the
> binary size. Please check the result in the -next branch, it should do
> what you need.
> 
> Sascha
> 
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox