Re: [PATCH v3 3/4] arm: boards: phytec-som-am335x: Update boot scripts

[Daniel Schultz <d.schultz@phytec.de>]

Hi Sascha,

Am 06.06.2017 um 07:46 schrieb Sascha Hauer:
> Hi Daniel,
> 
> On Fri, Jun 02, 2017 at 10:07:34AM +0200, Daniel Schultz wrote:
>> Hi,
>>
>> Am 17.05.2017 um 08:30 schrieb Sascha Hauer:
>>> On Fri, May 12, 2017 at 01:07:18PM +0200, Daniel Schultz wrote:
>>>> Expand the boot scripts with EMMC and add a default file source for
>>>> expansions.
>>>>
>>>> Removed "rw" and "rootwait" bootargs from existing boot scripts.
>>>> Added "rootflags='data=journal'" bootarg to SD card boot script.
>>>>
>>>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>>>> ---
>>>>    .../defaultenv-physom-am335x/boot/emmc                  |  7 +++++++
>>>>    .../phytec-som-am335x/defaultenv-physom-am335x/boot/mmc |  7 ++++---
>>>>    .../defaultenv-physom-am335x/boot/nand                  |  4 +++-
>>>>    .../phytec-som-am335x/defaultenv-physom-am335x/boot/net | 17 +++++++++++++++++
>>>>    .../phytec-som-am335x/defaultenv-physom-am335x/boot/spi |  4 +++-
>>>>    .../defaultenv-physom-am335x/init/bootsource            | 16 ++++++++++++----
>>>>    6 files changed, 46 insertions(+), 9 deletions(-)
>>>>    create mode 100644 arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
>>>>    create mode 100644 arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/net
>>>>
>>>> diff --git a/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc b/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
>>>> new file mode 100644
>>>> index 0000000..6ad5f87
>>>> --- /dev/null
>>>> +++ b/arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc
>>>> @@ -0,0 +1,7 @@
>>>> +#!/bin/sh
>>>> +
>>>> +[ -e /env/config-expansions ] && /env/config-expansions
>>>
>>> What do you have in these config-expansions or what do you expect to be
>>> there?
>>>
>>
>> These config-expanions files contain source commands for different
>> expansions like HDMI, LCD, WiFi, ... and are written from Yocto. We don't
>> want to bring these mainline, but without this line we have to overwrite
>> each boot script file from Yocto.
>>
>> Maybe this could be a good feature since we're not the only one with
>> expansion configurations.
> 
> I am generally open to such expansions, I just want to understand what's
> missing first.
> In this case I'd like to understand why you can't add an init script to
> /env/bin/init/ instead. If you want to extend the kernel commandline you
> could also add a nv variable to /env/nv/linux.bootargs.yocto.
> 

Oh I didn't know this part of the bin/init script. What do you think 
about this change? This would complete the config hierarchy by expensions:

+++ b/defaultenv/defaultenv-2-base/bin/init
@@ -25,6 +25,7 @@ magicvar -a global.allow_color "Allow color on the 
console (boolean)"
  [ -z "${global.editcmd}" ] && global.editcmd=sedit

  [ -e /env/config-board ] && /env/config-board
+[ -e /env/config-expansions ] && /env/config-expansions
  /env/config

  # allow to stop the boot before execute the /env/init/*

Otherwise I would move the config-expanions scripts to init/

The problem with the nv vars are the differences between the 
bootsources. Is there a way to add these vars with something like 
linux.bootargs.rootfs.mmc ?

-- 
Mit freundlichen Grüßen,
With best regards,
   Daniel Schultz

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox