From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 17/17] ARM: i.MX Phytec physom: Add deep-probe support
Date: Mon, 19 Apr 2021 09:12:37 +0200 [thread overview]
Message-ID: <62d9fd38-fa11-446d-1aee-2165a55f0fd5@pengutronix.de> (raw)
In-Reply-To: <20210416094943.3648-18-s.hauer@pengutronix.de>
Hi,
On 16.04.21 11:49, Sascha Hauer wrote:
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6q-pfla02");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6dl-pfla02");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6s-pfla02");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6q-pcaaxl3");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6q-pcm058-nand");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6q-pcm058-emmc");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6dl-pcm058-nand");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6qp-pcm058-nand");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6dl-pcm058-emmc");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6ul-pcl063-nand");
> +BAREBOX_DEEP_PROBE_ENABLE("phytec,imx6ul-pcl063-emmc");
How about changing BAREBOX_DEEP_PROBE_ENABLE so BAREBOX_DEEP_PROBE_ENABLE(physom_imx6_match);
works? Updated boards should be using board drivers anyway, so make it easier for them to
enable deep probe.
I'd go even further and require board drivers by having it take a driver_d * as argument
and introduce deep_probe_board_driver() that expands to postcore_platform_driver and
BAREBOX_DEEP_PROBE_ENABLE.
This would prevent having a board driver that's deep probe incompatible in the
first place, because it will likely not find the resources it requires that early
if it doesn't deep probe.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-04-19 7:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:49 [PATCH v4 00/17] barebox deep probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 01/17] imx53: remove unused imx53_add_nand Sascha Hauer
2021-04-16 9:49 ` [PATCH 02/17] of: platform: remove check of already added devices Sascha Hauer
2021-04-16 9:49 ` [PATCH 03/17] of: platform: Keep track of populated platform devices Sascha Hauer
2021-04-16 9:49 ` [PATCH 04/17] of: base: move memory init from DT to initcall Sascha Hauer
2021-04-16 9:49 ` [PATCH 05/17] of: base: move clock init from of_probe() to barebox_register_of() Sascha Hauer
2021-04-16 9:49 ` [PATCH 06/17] of: Set of_chosen and of_model earlier Sascha Hauer
2021-04-16 9:49 ` [PATCH 07/17] of: implement of_get_stdoutpath() Sascha Hauer
2021-04-16 9:49 ` [PATCH 08/17] initcall: add of_populate_initcall Sascha Hauer
2021-04-16 9:49 ` [PATCH 09/17] common: add initial barebox deep-probe support Sascha Hauer
2021-04-19 7:16 ` Ahmad Fatoum
2021-04-26 8:15 ` Marco Felsch
2021-04-16 9:49 ` [PATCH 10/17] pinctrl: Find controller node first Sascha Hauer
2021-04-16 9:49 ` [PATCH 11/17] common: Explicitly probe consoles earlier with deep probe Sascha Hauer
2021-04-16 9:49 ` [PATCH 12/17] pinctrl: Add deep probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 13/17] ARM: i.MX: esdctl: add deep-probe support Sascha Hauer
2021-04-16 9:49 ` [PATCH 14/17] ARM: stm32mp: ddrctrl: " Sascha Hauer
2021-04-16 9:49 ` [PATCH 15/17] ARM: boards: mx6-sabrelite: " Sascha Hauer
2021-04-16 9:49 ` [PATCH 16/17] ARM: i.MX Phytec physom: convert to board driver Sascha Hauer
2021-04-16 9:49 ` [PATCH 17/17] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer
2021-04-19 7:12 ` Ahmad Fatoum [this message]
2021-04-26 9:20 ` Marco Felsch
2021-04-26 9:26 ` Marco Felsch
2021-04-26 9:36 ` Ahmad Fatoum
2021-04-26 10:03 ` Marco Felsch
2021-04-19 7:35 ` [PATCH v4 00/17] barebox deep probe support Ahmad Fatoum
2021-04-28 10:28 ` [PATCH 1/3] fixup! common: add initial barebox deep-probe support Marco Felsch
2021-04-28 10:28 ` [PATCH 2/3] fixup! ARM: boards: mx6-sabrelite: add " Marco Felsch
2021-04-28 10:28 ` [PATCH 3/3] fixup! ARM: i.MX Phytec physom: Add " Marco Felsch
2021-04-28 10:42 ` [PATCH 1/3] fixup! common: add initial barebox " Ahmad Fatoum
2021-04-28 10:48 ` Marco Felsch
2021-04-28 11:21 ` Marco Felsch
2021-05-03 11:54 ` Sascha Hauer
2021-05-06 9:28 [PATCH v5 00/17] barebox deep probe support Sascha Hauer
2021-05-06 9:29 ` [PATCH 17/17] ARM: i.MX Phytec physom: Add deep-probe support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d9fd38-fa11-446d-1aee-2165a55f0fd5@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox