Re: [PATCH] ARM: beaglebone: add delay in lowlevel.c

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 08.01.25 16:14, Konstantin Kletschke wrote:
> Hello Sascha,
> 
> On Wed, Jan 08, 2025 at 03:32:04PM +0100, Sascha Hauer wrote:
> 
>> Calling udelay(1000) and adding a comment saying it delays 1.8ms looks
>> inconsistent. Maybe better count up to 2 in __udelay() above which makes
> 
> I completely agree somehow since the time is not even constant and depends on
> the PLL settings just done before.
> 
> I suggest the following:
> 
> Removing the "* 3" fancy thingy in the function's loop, calling the
> function with 3000 instead of 1000, changing comment to "needed on some
> Beaglebone Black for warm start after reset".
> 
> That would be as simple as possible.

It would be nice to have the comment more verbose. e.g. that this issue
was observed on new Seeed-produced BBBs is an intersting info IMO.

> 
> Regards
> Konsti
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |