mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
	barebox@lists.infradead.org, Lucas Stach <lst@pengutronix.de>
Subject: Re: [PATCH v1] net: designware: eqos: fix link speed configuration for speed < 1000
Date: Wed, 13 Apr 2022 15:54:54 +0200	[thread overview]
Message-ID: <63ddfbdb-9d82-43fc-189d-d6b3b53e11f3@pengutronix.de> (raw)
In-Reply-To: <20220413123708.623736-1-o.rempel@pengutronix.de>

Hello Oleksij,

On 13.04.22 14:37, Oleksij Rempel wrote:
> Put phy_device_connect() after MAC/DMA reset, otherwise link speed
> configuration will be zeroed by the MAC/DMA reset. By an accident zero
> configuration equal to the speed 1000, so it was still working for many users.

This hunk used to be farther down, but Lucas moved it in
7c5c6561f0ca ("net: designware: eqos: attach PHY earlier").

I suspect your patch might break his hardware configuration.

Cheers,
Ahmad

> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/designware_eqos.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> index 6b372e4274..d93cccd634 100644
> --- a/drivers/net/designware_eqos.c
> +++ b/drivers/net/designware_eqos.c
> @@ -390,11 +390,6 @@ static int eqos_start(struct eth_device *edev)
>  	int ret;
>  	int i;
>  
> -	ret = phy_device_connect(edev, &eqos->miibus, eqos->phy_addr,
> -				 eqos->ops->adjust_link, 0, eqos->interface);
> -	if (ret)
> -		return ret;
> -
>  	setbits_le32(&eqos->dma_regs->mode, EQOS_DMA_MODE_SWR);
>  
>  	ret = readl_poll_timeout(&eqos->dma_regs->mode, mode_set,
> @@ -405,6 +400,11 @@ static int eqos_start(struct eth_device *edev)
>  		return ret;
>  	}
>  
> +	ret = phy_device_connect(edev, &eqos->miibus, eqos->phy_addr,
> +				 eqos->ops->adjust_link, 0, eqos->interface);
> +	if (ret)
> +		return ret;
> +
>  	/* Reset above clears MAC address */
>  	eqos_set_ethaddr(edev, eqos->macaddr);
>  


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-04-13 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 12:37 Oleksij Rempel
2022-04-13 13:54 ` Ahmad Fatoum [this message]
2022-04-14  4:48   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63ddfbdb-9d82-43fc-189d-d6b3b53e11f3@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=lst@pengutronix.de \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox