[PATCH] net: designware: eqos: remove done TODO

[PATCH] net: designware: eqos: remove done TODO

[Ahmad Fatoum]

The todo split comment is a left-over from refactoring. Remove it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/net/designware_stm32.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/designware_stm32.c b/drivers/net/designware_stm32.c
index ed54ff2b2615..bb6781fb3450 100644
--- a/drivers/net/designware_stm32.c
+++ b/drivers/net/designware_stm32.c
@@ -204,7 +204,6 @@ static void eqos_stop_stm32(struct eth_device *edev)
 	clk_bulk_disable(priv->num_clks, priv->clks);
 }
 
-// todo split!
 static struct eqos_ops stm32_ops = {
 	.init = eqos_init_stm32,
 	.get_ethaddr = eqos_get_ethaddr,
-- 
2.24.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: designware: eqos: remove done TODO

[Sascha Hauer]

On Thu, Nov 14, 2019 at 02:28:08PM +0100, Ahmad Fatoum wrote:
> The todo split comment is a left-over from refactoring. Remove it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/net/designware_stm32.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: designware: eqos: remove done TODO

[Ahmad Fatoum]

Hello Sascha,

On 11/15/19 2:33 PM, Sascha Hauer wrote:
> On Thu, Nov 14, 2019 at 02:28:08PM +0100, Ahmad Fatoum wrote:
>> The todo split comment is a left-over from refactoring. Remove it.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  drivers/net/designware_stm32.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> Applied, thanks

I can't find this commit in upstream/next and the string still exists.
Could you take a look?

Thanks,
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: designware: eqos: remove done TODO

[Sascha Hauer]

Hi Ahmad,

On Wed, Dec 04, 2019 at 02:05:36PM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 11/15/19 2:33 PM, Sascha Hauer wrote:
> > On Thu, Nov 14, 2019 at 02:28:08PM +0100, Ahmad Fatoum wrote:
> >> The todo split comment is a left-over from refactoring. Remove it.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >>  drivers/net/designware_stm32.c | 1 -
> >>  1 file changed, 1 deletion(-)
> > 
> > Applied, thanks
> 
> I can't find this commit in upstream/next and the string still exists.
> Could you take a look?

Hm, indeed. I don't know where it got lost. I applied it now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox