Re: [PATCH 2/3] ARM: stm32mp: add Linux Automation TAC board

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sascha,

On 4/14/25 13:42, Ahmad Fatoum wrote:
>> This check only matches for minor revision 0. Shouldn't the minor
>> version rather be ignored here?
> 
> I am not sure if a generation is always equal to the major version - 1.
> It seems we have no minor revisions != 0 in the field.
> 
> If Leonard (Cc'd) doesn't object, I'll mask away the lower 2 bits for v2.

Looking at the FairyTux in the follow-up commit, updating the major
version in copper was overlooked and thus a minor update was done.
This broke the 1:1 correspondence between generations and major versions.

I would thus like to keep the revision code unchanged for the LXA TAC to
be identical to what we have on the FairyTux.

Thanks,
Ahmad

> 
>>> +ENTRY_FUNCTION(start_stm32mp15xc_lxa_tac, r0, r1, r2)
>>> +{
>>> +	stm32mp_cpu_lowlevel_init();
>>> +
>>> +	/*
>>> +	 * stm32mp_cpu_lowlevel_init sets up a stack. Do the remaining
>>> +	 * init in a non-naked function. Register r2 points to the fdt
>>> +	 * from the FIT image which can be used as a default.
>>> +	 */
>>
>> "the fdt from the FIT image" seems to imply that this entry is only used
>> as a 2nd state entry, but it's used as a 1st stage entry as well, isn't
>> it?
> 
> s/FIT/FIP. First stage bootloader is TF-A.
> 
>> I would rephrase that to something like "in case of a 2nd stage boot r2
>> points to the fdt..."
> 
> There is no first stage boot.
> 
> Cheers,
> Ahmad
> 
>>
>> Sascha
>>
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |