From: Ian Abbott <abbotti@mev.co.uk>
To: barebox@lists.infradead.org
Subject: watchdog_disable() in Cyclone V reset manager
Date: Mon, 8 Apr 2019 15:10:06 +0100 [thread overview]
Message-ID: <67655ee5-da5f-2b99-2d1d-ab6c66e4dd48@mev.co.uk> (raw)
"arch/arm/mach-socfpga/cyclone5-reset-manager.c" defines a global
function 'void watchdog_disable(void)'. Nothing calls it. The compiler
issues a warning:
/mnt/lindata/work/abbotti/barebox_git/barebox-next/arch/arm/mach-socfpga/cyclone5-reset-manager.c:26:6:
warning: no previous prototype for ‘watchdog_disable’ [-Wmissing-prototypes]
void watchdog_disable(void)
^~~~~~~~~~~~~~~~
Since nothing in the shipped code calls it, should we get rid of it? If
not, it should be declared in a header file somewhere.
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-04-08 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:10 Ian Abbott [this message]
2019-04-10 6:21 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67655ee5-da5f-2b99-2d1d-ab6c66e4dd48@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox