watchdog_disable() in Cyclone V reset manager

watchdog_disable() in Cyclone V reset manager

[Ian Abbott]

"arch/arm/mach-socfpga/cyclone5-reset-manager.c" defines a global 
function 'void watchdog_disable(void)'.  Nothing calls it.  The compiler 
issues a warning:

/mnt/lindata/work/abbotti/barebox_git/barebox-next/arch/arm/mach-socfpga/cyclone5-reset-manager.c:26:6: 
warning: no previous prototype for ‘watchdog_disable’ [-Wmissing-prototypes]
  void watchdog_disable(void)
       ^~~~~~~~~~~~~~~~

Since nothing in the shipped code calls it, should we get rid of it?  If 
not, it should be declared in a header file somewhere.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: watchdog_disable() in Cyclone V reset manager

[Sascha Hauer]

On Mon, Apr 08, 2019 at 03:10:06PM +0100, Ian Abbott wrote:
> "arch/arm/mach-socfpga/cyclone5-reset-manager.c" defines a global function
> 'void watchdog_disable(void)'.  Nothing calls it.  The compiler issues a
> warning:
> 
> /mnt/lindata/work/abbotti/barebox_git/barebox-next/arch/arm/mach-socfpga/cyclone5-reset-manager.c:26:6:
> warning: no previous prototype for ‘watchdog_disable’ [-Wmissing-prototypes]
>  void watchdog_disable(void)
>       ^~~~~~~~~~~~~~~~
> 
> Since nothing in the shipped code calls it, should we get rid of it?  If
> not, it should be declared in a header file somewhere.

watchdog_disable() goes back to the initial socfpga commit, so when
nothing uses it now I think we can remove it. The watchdog disabling
may also be handled already in socfpga_lowlevel_init() which also
touches the same registers.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox