From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 05 May 2021 12:40:27 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leEx9-0007hu-Rz for lore@lore.pengutronix.de; Wed, 05 May 2021 12:40:27 +0200 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leEx8-0001wm-K6 for lore@pengutronix.de; Wed, 05 May 2021 12:40:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BU0tQbGrmVCO78TdjAKYlQYyIObtfCrwmndGXKHoyGk=; b=YalaMo+Gb34oHkYpwBKWgUqoi jsZzf8AeurTmKxrHzMpNpZkEmF8hoEugQzKuQk3KD5EfAk/2ZDpPvlw8iMojvGyeSGc/Da93bHsDE peNe27jgJIGsJrNDTxVvMHCrPqUlE43w8gJig/4Y2sXfi08+q4UgmSsFIKjv/jauSjHBSziE5caKl U9tT/nABJwbX1Px/Yy9ocWvVWZyNoLYxMAGDVGmXkk26/i0WpFTSh308mas5KOhgk2YWnBpqSFzRk ln08CrITMiPpSpJhGp4GNSSO5q3DonLFc0SPZV9CwKU78/1IJ1S8XMX2VkzA8+Z6oVTgQ73gZQvqq OM816ZPng==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leEw9-000zXA-Ss; Wed, 05 May 2021 10:39:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leEw3-000zWS-Eg for barebox@desiato.infradead.org; Wed, 05 May 2021 10:39:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=MjzeIoSFqC1Z8ogCZW6qJbifeTypt2C0Vc68C3IIHCc=; b=U8wN6HaR8lV9ayDaauD81Q7f7p DJRi5yu3OjxG3ButCIznheVvAwYDePPN7CkMCCykkmBQHc+f4GMe20EVzVVuw0UoGnkuITVTgk5oo LQJ2fnivQJvngaagPNF3VgDG0+DRVhpp/e6fibElO80rsXA7MoVUNPuwpULfGAbE8573PFfcgXDhf raKzzksR0OPBGmZIXCN0ouiS/JScVgPUiUlq4ZWQUsaLK8IrzClhdzsot1u/LZyOtj1bmTtgtaj8y BJE8e9bX5kxiTPCpFSDhmnLsr27qqGj0OoHBbJx4epV6yPoh/3U6ZJOLMj89Lw9YRwGK6EctaplkG KV+eLolg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leEvz-004gKQ-TU for barebox@lists.infradead.org; Wed, 05 May 2021 10:39:18 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leEvy-0001rK-HR; Wed, 05 May 2021 12:39:14 +0200 To: Antony Pavlov , barebox@lists.infradead.org References: <20210505100900.88141-1-antonynpavlov@gmail.com> <20210505100900.88141-6-antonynpavlov@gmail.com> From: Ahmad Fatoum Message-ID: <6afef336-25fc-9b4f-eb4c-8e99f7b118ac@pengutronix.de> Date: Wed, 5 May 2021 12:39:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210505100900.88141-6-antonynpavlov@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_033916_152662_62076F54 X-CRM114-Status: GOOD ( 32.27 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2001:8b0:10b:1:d65d:64ff:fe57:4e05 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 5/9] spi: add litex spiflash driver X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hello Antony, On 05.05.21 12:08, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > drivers/spi/Kconfig | 3 + > drivers/spi/Makefile | 1 + > drivers/spi/litex_spiflash.c | 242 +++++++++++++++++++++++++++++++++++ > 3 files changed, 246 insertions(+) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 323d93efeb..714d30e909 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -74,6 +74,9 @@ config DRIVER_SPI_IMX_2_3 > depends on ARCH_IMX50 || ARCH_IMX51 || ARCH_IMX53 || ARCH_IMX6 || ARCH_IMX7 || ARCH_IMX8MQ > default y > > +config DRIVER_SPI_LITEX_SPIFLASH > + bool "Litex SPIFLASH bitbang master driver" The SPI controller is called SPIFLASH? > + > config DRIVER_SPI_MXS > bool "i.MX (23,28) SPI Master driver" > depends on ARCH_IMX28 > diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile > index 908d514a01..ac95ffc1db 100644 > --- a/drivers/spi/Makefile > +++ b/drivers/spi/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_DRIVER_SPI_ATH79) += ath79_spi.o > obj-$(CONFIG_DRIVER_SPI_GPIO) += gpio_spi.o > obj-$(CONFIG_DRIVER_SPI_FSL_QUADSPI) += spi-fsl-qspi.o > obj-$(CONFIG_DRIVER_SPI_IMX) += imx_spi.o > +obj-$(CONFIG_DRIVER_SPI_LITEX_SPIFLASH) += litex_spiflash.o > obj-$(CONFIG_DRIVER_SPI_MVEBU) += mvebu_spi.o > obj-$(CONFIG_DRIVER_SPI_MXS) += mxs_spi.o > obj-$(CONFIG_DRIVER_SPI_ALTERA) += altera_spi.o > diff --git a/drivers/spi/litex_spiflash.c b/drivers/spi/litex_spiflash.c > new file mode 100644 > index 0000000000..2d6858c580 > --- /dev/null > +++ b/drivers/spi/litex_spiflash.c > @@ -0,0 +1,242 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (C) 2020 Antony Pavlov > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include Unused now, I think. > + > +struct litex_spiflash_spi { > + struct spi_master master; > + void __iomem *regs; > + u32 val; > +}; > + > +#define SPIFLASH_BITBANG 0x0 > +#define SPIFLASH_BB_MOSI BIT(0) > +#define SPIFLASH_BB_CLK BIT(1) > +#define SPIFLASH_BB_CSN BIT(2) > +#define SPIFLASH_BB_DIR BIT(3) > + > +#define SPIFLASH_MISO 0x4 > +#define SPIFLASH_BITBANG_EN 0x8 > + > +static inline u32 litex_spiflash_spi_rr(struct litex_spiflash_spi *sp, int reg) > +{ > + return readl(sp->regs + reg); > +} > + > +static inline void litex_spiflash_spi_wr(struct litex_spiflash_spi *sp, u32 val, int reg) > +{ > + writel(val, sp->regs + reg); > +} > + > +static inline void setbits(struct litex_spiflash_spi *sp, int bits, int on) > +{ > + /* > + * We are the only user of SCSPTR so no locking is required. > + * Reading bit 2 and 0 in SCSPTR gives pin state as input. > + * Writing the same bits sets the output value. > + * This makes regular read-modify-write difficult so we > + * use sp->val to keep track of the latest register value. > + */ > + > + if (on) > + sp->val |= bits; > + else > + sp->val &= ~bits; > + > + litex_spiflash_spi_wr(sp, sp->val, SPIFLASH_BITBANG); > +} > + > +static inline struct litex_spiflash_spi *litex_spiflash_spidev_to_sp(struct spi_device *spi) > +{ > + return container_of(spi->master, struct litex_spiflash_spi, master); > +} > + > +static inline void setsck(struct spi_device *spi, int on) > +{ > + struct litex_spiflash_spi *sc = litex_spiflash_spidev_to_sp(spi); > + > + setbits(sc, SPIFLASH_BB_CLK, on); > +} > + > +static inline void setmosi(struct spi_device *spi, int on) > +{ > + struct litex_spiflash_spi *sc = litex_spiflash_spidev_to_sp(spi); > + > + sc->val &= ~SPIFLASH_BB_DIR; > + setbits(sc, SPIFLASH_BB_MOSI, on); > +} > + > +static inline u32 getmiso(struct spi_device *spi) > +{ > + struct litex_spiflash_spi *sc = litex_spiflash_spidev_to_sp(spi); > + > + setbits(sc, SPIFLASH_BB_DIR, 1); > + return !!((litex_spiflash_spi_rr(sc, SPIFLASH_MISO) & 1)); > +} > + > +#define spidelay(nsecs) udelay(nsecs/1000) Unused. > + > +#include "spi-bitbang-txrx.h" > + > +static inline void litex_spiflash_spi_chipselect(struct litex_spiflash_spi *sc, int on) > +{ > + setbits(sc, SPIFLASH_BB_CSN, on); > +} > + > +static int litex_spiflash_spi_setup(struct spi_device *spi) > +{ > + struct spi_master *master = spi->master; > + struct device_d spi_dev = spi->dev; > + > + if (spi->bits_per_word != 8) { > + dev_err(master->dev, "master doesn't support %d bits per word requested by %s\n", > + spi->bits_per_word, spi_dev.name); > + return -EINVAL; > + } > + > + if ((spi->mode & (SPI_CPHA | SPI_CPOL)) != SPI_MODE_0) { > + dev_err(master->dev, "master doesn't support SPI_MODE%d requested by %s\n", > + spi->mode & (SPI_CPHA | SPI_CPOL), spi_dev.name); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int litex_spiflash_spi_read(struct spi_device *spi, void *buf, size_t nbyte) > +{ > + ssize_t cnt = 0; > + u8 *rxf_buf = buf; > + > + while (cnt < nbyte) { > + *rxf_buf = bitbang_txrx_be_cpha1(spi, 1000, 1, 0, 8); > + rxf_buf++; > + cnt++; > + } > + > + return cnt; > +} > + > +static int litex_spiflash_spi_write(struct spi_device *spi, > + const void *buf, size_t nbyte) > +{ > + ssize_t cnt = 0; > + const u8 *txf_buf = buf; > + > + while (cnt < nbyte) { > + bitbang_txrx_be_cpha1(spi, 1000, 1, (u32)*txf_buf, 8); > + txf_buf++; > + cnt++; > + } > + > + return 0; > +} > + > +static int litex_spiflash_spi_transfer(struct spi_device *spi, struct spi_message *mesg) > +{ > + struct litex_spiflash_spi *sc = litex_spiflash_spidev_to_sp(spi); > + struct spi_transfer *t; > + > + mesg->actual_length = 0; > + > + /* activate chip select signal */ > + litex_spiflash_spi_chipselect(sc, 0); > + > + list_for_each_entry(t, &mesg->transfers, transfer_list) { > + > + if (t->tx_buf) > + litex_spiflash_spi_write(spi, t->tx_buf, t->len); > + > + if (t->rx_buf) > + litex_spiflash_spi_read(spi, t->rx_buf, t->len); > + > + mesg->actual_length += t->len; > + } > + > + /* inactivate chip select signal */ > + litex_spiflash_spi_chipselect(sc, 1); > + > + return 0; > +} > + > +static void litex_spiflash_spi_enable(struct litex_spiflash_spi *sp) > +{ > + u32 val; > + > + /* set SPIFLASH_BB_DIR = 0 */ > + val = SPIFLASH_BB_CSN | SPIFLASH_BB_CLK | SPIFLASH_BB_MOSI; > + litex_spiflash_spi_wr(sp, val, SPIFLASH_BITBANG); > + > + /* enable GPIO mode */ > + litex_spiflash_spi_wr(sp, 1, SPIFLASH_BITBANG_EN); > +} > + > +static void litex_spiflash_spi_disable(struct litex_spiflash_spi *sp) > +{ > + /* disable GPIO mode */ > + litex_spiflash_spi_wr(sp, 0, SPIFLASH_BITBANG_EN); > +} > + > +static int litex_spiflash_spi_probe(struct device_d *dev) > +{ > + struct resource *iores; > + struct spi_master *master; > + struct litex_spiflash_spi *litex_spiflash_spi; > + > + litex_spiflash_spi = xzalloc(sizeof(*litex_spiflash_spi)); > + dev->priv = litex_spiflash_spi; > + > + master = &litex_spiflash_spi->master; > + master->dev = dev; > + > + master->bus_num = dev->id; > + master->setup = litex_spiflash_spi_setup; > + master->transfer = litex_spiflash_spi_transfer; > + master->num_chipselect = 1; > + > + iores = dev_request_mem_resource(dev, 0); > + if (IS_ERR(iores)) > + return PTR_ERR(iores); > + litex_spiflash_spi->regs = IOMEM(iores->start); > + > + litex_spiflash_spi_enable(litex_spiflash_spi); > + > + /* inactivate chip select signal */ Nitpick s/inactivate/deactivate/ > + litex_spiflash_spi_chipselect(litex_spiflash_spi, 1); > + > + spi_register_master(master); > + > + return 0; > +} > + > +static void litex_spiflash_spi_remove(struct device_d *dev) > +{ > + struct litex_spiflash_spi *sp = dev->priv; > + > + litex_spiflash_spi_disable(sp); > +} > + > +static __maybe_unused struct of_device_id litex_spiflash_spi_dt_ids[] = { > + { > + .compatible = "litex,spiflash", > + }, > + { > + /* sentinel */ > + } > +}; > + > +static struct driver_d litex_spiflash_spi_driver = { > + .name = "litex-spiflash", > + .probe = litex_spiflash_spi_probe, > + .remove = litex_spiflash_spi_remove, > + .of_compatible = DRV_OF_COMPAT(litex_spiflash_spi_dt_ids), > +}; > +device_platform_driver(litex_spiflash_spi_driver); > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox