mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] ARM: mmu_32: fix setting up zero page when it is in SDRAM
Date: Thu, 1 Jun 2023 09:00:03 +0200	[thread overview]
Message-ID: <6e731105-166e-5210-f66d-5ded68be76bd@pengutronix.de> (raw)
In-Reply-To: <20230601064604.GC18491@pengutronix.de>

On 01.06.23 08:46, Sascha Hauer wrote:
> On Wed, May 31, 2023 at 02:40:13PM +0200, Ahmad Fatoum wrote:
>> On 31.05.23 14:38, Sascha Hauer wrote:
>>> On Wed, May 31, 2023 at 01:58:33PM +0200, Ahmad Fatoum wrote:
>>>>> From b6e5c92682467496bd9c57918996f1feffda2dd6 Mon Sep 17 00:00:00 2001
>>>>> From: Sascha Hauer <s.hauer@pengutronix.de>
>>>>> Date: Wed, 31 May 2023 11:58:51 +0200
>>>>> Subject: [PATCH] ARM: mmu_32: fix setting up zero page when it is in SDRAM
>>>>>
>>>>> We used to skip setting the zero page to faulting when SDRAM starts at
>>>>> 0x0. As bootm code now explicitly sets the zero page accessible before
>>>>> copying ATAGs there this should no longer be necessary, so
>>>>> unconditionally set the zero page to faulting during MMU startup.  This
>>>>> also moves the zero page and vector table setup after the point the
>>>>> SDRAM has been mapped cachable, because otherwise the zero page and
>>>>> possibly the vector table mapping would be overwritten.
>>>>>
>>>>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>>>>> ---
>>>>>  arch/arm/cpu/mmu_32.c | 23 +++++++++--------------
>>>>>  1 file changed, 9 insertions(+), 14 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/cpu/mmu_32.c b/arch/arm/cpu/mmu_32.c
>>>>> index c4e5a3bb0a..14775768a3 100644
>>>>> --- a/arch/arm/cpu/mmu_32.c
>>>>> +++ b/arch/arm/cpu/mmu_32.c
>>>>> @@ -461,19 +461,14 @@ static int set_vector_table(unsigned long adr)
>>>>>  
>>>>>  static void create_zero_page(void)
>>>>
>>>> Is this commit incomplete? Vectors should be set up unconditionally and
>>>> create_zero_page should be called after it.
>>>
>>> Vectors are set up unconditionally and create_zero_page() is called the
>>> same way as before.
>>
>> So zero page is requested first and then on platforms with vector at
>> address 0 requesting fails and we are left without configured IVT?
> 
> I think you are misreading the patch. Please look at it again.
> create_zero_page() is called only when the vector table is not at 0x0.
> It has been like that without this patch, the patch doesn't change
> anything here.

No I get it.

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks for bearing with me,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2023-06-01  7:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 10:35 [PATCH v2 1/2] ARM: set zero page accessible before copying ATAGs there Sascha Hauer
2023-05-31 10:35 ` [PATCH v2 2/2] ARM: mmu_32: fix setting up zero page when it is in SDRAM Sascha Hauer
2023-05-31 10:45   ` Ahmad Fatoum
2023-05-31 11:21     ` Sascha Hauer
2023-05-31 11:58       ` Ahmad Fatoum
2023-05-31 12:38         ` Sascha Hauer
2023-05-31 12:40           ` Ahmad Fatoum
2023-06-01  6:46             ` Sascha Hauer
2023-06-01  7:00               ` Ahmad Fatoum [this message]
2023-05-31 10:40 ` [PATCH v2 1/2] ARM: set zero page accessible before copying ATAGs there Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e731105-166e-5210-f66d-5ded68be76bd@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox