From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Holger Assmann <h.assmann@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing
Date: Fri, 8 Nov 2024 12:43:51 +0100 [thread overview]
Message-ID: <6eb56bb2-9b61-457a-9cea-45bfa7075d08@pengutronix.de> (raw)
In-Reply-To: <20241108105751.1872681-1-h.assmann@pengutronix.de>
Hello Holger,
Thanks for your fix.
On 08.11.24 11:57, Holger Assmann wrote:
> Besides its power domain, the NPU node itself also needs to be disabled
> in the kernel device tree if no respective hardware is present at the
> SoC.
>
> The power domain has already been dealt with by upstream commit
> 924101c81d6e ("ARM: i.MX8MP: add feature controller support for Plus").
> This patch adds the necessary entry for the NPU node.
> > Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de
Cheers,
Ahmad
> ---
> arch/arm/dts/imx8mp.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
> index 4d1f1bf588..1604fa13a5 100644
> --- a/arch/arm/dts/imx8mp.dtsi
> +++ b/arch/arm/dts/imx8mp.dtsi
> @@ -99,6 +99,10 @@ &vpumix_blk_ctrl {
> barebox,feature-gates = <&feat IMX8M_FEAT_VPU>;
> };
>
> +&npu {
> + barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
> +};
> +
> &pgc_mlmix {
> barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-11-08 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 10:57 Holger Assmann
2024-11-08 11:43 ` Ahmad Fatoum [this message]
2024-11-12 9:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb56bb2-9b61-457a-9cea-45bfa7075d08@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=h.assmann@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox