From: Andrej Picej <andrej.picej@norik.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/3] Revert "scripts/common: fix write_file when opened with mmap"
Date: Mon, 28 Feb 2022 12:40:46 +0100 [thread overview]
Message-ID: <6f8093c4-7f4e-c0ad-41d3-f358349a256f@norik.com> (raw)
In-Reply-To: <20220228101634.GJ19585@pengutronix.de>
On 28. 02. 22 11:16, Sascha Hauer wrote:
> On Thu, Feb 24, 2022 at 02:22:12PM +0100, Andrej Picej wrote:
>> Hi Sascha,
>>
>> sorry for responding this late, but we are still getting the same errors as
>> before when using bareboximd with these three patches.
>>
>> Are you sure we can revert this patch? The file can still be opened in
>> bareboximd with mmap(), and then be written with this write_file(), which
>> fails with the same error:
>>
>>> Cannot write to barebox.bin: Bad address
>>> CRC: write crc token to barebox.bin failed: -14
>>> Bad address
>
> Damn, my bad. It seems my brain was on vacation. I just created a fix
> for this, you should be on Cc.
>
No worries, it happens :). Thanks for a quick fix. it works as intended :).
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-02-28 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 9:42 [PATCH 1/3] scripts/common: Do not mmap in read_file_2() Sascha Hauer
2022-02-11 9:42 ` [PATCH 2/3] scripts: bareboximd: Use mmap when possible Sascha Hauer
2022-02-11 9:42 ` [PATCH 3/3] Revert "scripts/common: fix write_file when opened with mmap" Sascha Hauer
2022-02-24 13:22 ` Andrej Picej
2022-02-28 10:16 ` Sascha Hauer
2022-02-28 11:40 ` Andrej Picej [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8093c4-7f4e-c0ad-41d3-f358349a256f@norik.com \
--to=andrej.picej@norik.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox