mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Documentation: dt-bindings: leds: document 'default-on' trigger
Date: Wed, 22 Nov 2023 06:24:21 +0100	[thread overview]
Message-ID: <6rzfz65pe4.fsf@pengutronix.de> (raw)
In-Reply-To: <20231121162009.160644-1-rhi@pengutronix.de>

Hi Roland,

On Tue, Nov 21 2023 at 17:20 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> The default-on trigger has been supported in barebox since commit
> 767c6b4a814a2a000f3b (2014-02-28, Sascha Hauer: "led: Add default-on
> trigger").
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/leds/common.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.rst b/Documentation/devicetree/bindings/leds/common.rst
> index 09b4e401bc2c..ad94ceb506b1 100644
> --- a/Documentation/devicetree/bindings/leds/common.rst
> +++ b/Documentation/devicetree/bindings/leds/common.rst
> @@ -9,6 +9,7 @@ Common leds properties
>      * ``net`` - LED indicates network activity (tx and rx)
>      * ``net-rx`` - LED indicates network activity (rx only)
>      * ``net-tx`` - LED indicates network activity (tx only)
> +    * ``default-on`` – LED is switched on by default

the lines before utilize the character '-' while in your new line a '–'
is used. I think this should be consistent in one or the other
direction.

Best regards
Ulrich


>  * ``label``: The label for this LED. If omitted, the label is taken
>    from the node name (excluding the unit address).
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-11-22  5:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 16:20 Roland Hieber
2023-11-22  5:24 ` Ulrich Ölmann [this message]
2023-11-22  9:48   ` Roland Hieber
2023-11-22  9:51     ` [PATCH v2] " Roland Hieber
2023-11-22 15:25       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6rzfz65pe4.fsf@pengutronix.de \
    --to=u.oelmann@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox