From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>,
Oleksij Rempel <o.rempel@pengutronix.de>,
barebox@lists.infradead.org
Cc: david@protonic.nl
Subject: Re: [PATCH v2 3/3] devinfo: do not dump the device node for the root node
Date: Wed, 15 Jul 2020 15:57:26 +0200 [thread overview]
Message-ID: <70e33722-d124-257a-f786-d7c64a11351c@pengutronix.de> (raw)
In-Reply-To: <8c21cf799ad857209c795b5db79efc476adf924f.camel@pengutronix.de>
On 7/15/20 2:35 PM, Lucas Stach wrote:
> Am Mittwoch, den 15.07.2020, 12:10 +0200 schrieb Oleksij Rempel:
>> In case the device is a root node, then do not dump it. Otherwise it will be a
>> mess.
>
> This is waaay too unspecific for a commit message. What happens without
> this patch and how does this patch fix it?
While at it, you could move this patch here to the series start, so bisection can't
end on a patch with the messy devinfo output.
>
> Regards,
> Lucas
>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>> commands/devinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/commands/devinfo.c b/commands/devinfo.c
>> index 81956b1cc0..018a7c4167 100644
>> --- a/commands/devinfo.c
>> +++ b/commands/devinfo.c
>> @@ -99,7 +99,7 @@ static int do_devinfo(int argc, char *argv[])
>> printf("\n");
>> }
>> #ifdef CONFIG_OFDEVICE
>> - if (dev->device_node) {
>> + if (dev->device_node && dev->device_node != of_get_root_node()) {
>> printf("Device node: %s\n", dev->device_node->full_name);
>> of_print_nodes(dev->device_node, 0);
>> }
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-07-15 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 10:10 [PATCH v2 0/3] introduce board-driver support Oleksij Rempel
2020-07-15 10:10 ` [PATCH v2 1/3] of: base: register DT root as device Oleksij Rempel
2020-07-15 10:10 ` [PATCH v2 2/3] ARM: embest-riotboard: port board file to the driver model Oleksij Rempel
2020-07-15 10:10 ` [PATCH v2 3/3] devinfo: do not dump the device node for the root node Oleksij Rempel
2020-07-15 12:35 ` Lucas Stach
2020-07-15 13:57 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e33722-d124-257a-f786-d7c64a11351c@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david@protonic.nl \
--cc=l.stach@pengutronix.de \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox