mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
	Christian Hemp <christian.hemp@gmail.com>
Subject: Re: [PATCH] ARM: Phytec phyCORE i.MX6: delete wrong memory node
Date: Wed, 29 Apr 2020 14:00:55 +0200	[thread overview]
Message-ID: <72aafb2f-d612-23b4-f1b3-d42c5b5ce503@phytec.de> (raw)
In-Reply-To: <20200429112914.5751-1-s.hauer@pengutronix.de>

Hi Sascha,

On 29.04.20 13:29, Sascha Hauer wrote:
> The phyCORE i.MX6 has two memory nodes in the device tree. /memory comes

Here and in the subject line you mention the phyCORE-i.MX 6 but it is 
actually the phyFLEX which you change.

Besides that,
Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>

> from the barebox dtsi file and contains dummy values. This is
> unnecessary, barebox will create a memory node when booting the kernel.
> The other one comes from the Kernel dtsi and causes more harm. The
> memory in the node has a size of 2GiB. Not all boards have so much
> memory, since 8226f7f909 ("of: base: parse all available memory nodes")
> this node is no longer ignored and now all boards are assumed to have
> 2GiB of memory. Remove the node using /delete-node/
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>   arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index 841ad653b2..3cb8b3782a 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -12,10 +12,7 @@
>   #include <arm/imx6qdl-phytec-pfla02.dtsi>
>   
>   / {
> -	memory {
> -		/* let barebox fill the memory node */
> -		reg = <0 0>;
> -	};
> +	/delete-node/ memory@10000000;
>   
>   	chosen {
>   		environment-nand {
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-04-29 12:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 11:29 Sascha Hauer
2020-04-29 12:00 ` Stefan Riedmüller [this message]
2020-04-30  5:44   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72aafb2f-d612-23b4-f1b3-d42c5b5ce503@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=christian.hemp@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox