From: Oleksij Rempel <linux@rempel-privat.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/3] lib: random: get_random_bytes from HWRNG if present
Date: Fri, 17 Mar 2017 15:30:43 +0100 [thread overview]
Message-ID: <72cf75e7-ea1b-11f1-570d-b66d6bb283f2@rempel-privat.de> (raw)
In-Reply-To: <20170317123040.2jyk3gij2z4v2rgd@pengutronix.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1301 bytes --]
Am 17.03.2017 um 13:30 schrieb Sascha Hauer:
> On Thu, Mar 16, 2017 at 06:31:45AM +0100, Oleksij Rempel wrote:
>> From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>
>> Instead of generating pseudo random numbers, get random bytes
>> from an optional HW generator, if enabled and registered.
>>
>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>> lib/random.c | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/lib/random.c b/lib/random.c
>> index 210fea994..42c0f83b7 100644
>> --- a/lib/random.c
>> +++ b/lib/random.c
>> @@ -1,5 +1,6 @@
>> #include <common.h>
>> #include <stdlib.h>
>> +#include <linux/hw_random.h>
>>
>> static unsigned int random_seed;
>>
>> @@ -22,6 +23,24 @@ void get_random_bytes(void *_buf, int len)
>> {
>> char *buf = _buf;
>>
>> + if (IS_ENABLED(CONFIG_HWRNG)) {
>> + struct hwrng *rng;
>> + int bytes;
>> +
>> + rng = hwrng_get_first();
>> + if (!IS_ERR(rng)) {
>> + while (len) {
>> + bytes = hwrng_get_data(rng, _buf, len, 1);
>> + if (!bytes)
>> + goto sw_fallback;
>
> hwrng_get_data() looks like it could return a negative error code.
hm.. good point.
--
Regards,
Oleksij
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-17 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 5:31 [PATCH v2 0/3] upstream hwrng framework Oleksij Rempel
2017-03-16 5:31 ` [PATCH v2 1/3] drivers: add simple hw_random implementation Oleksij Rempel
2017-03-16 5:31 ` [PATCH v2 2/3] lib: random: get_random_bytes from HWRNG if present Oleksij Rempel
2017-03-17 12:30 ` Sascha Hauer
2017-03-17 14:30 ` Oleksij Rempel [this message]
2017-03-16 5:31 ` [PATCH v2 3/3] caamrng: port to hwrng framework Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72cf75e7-ea1b-11f1-570d-b66d6bb283f2@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox