From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
barebox@lists.infradead.org
Subject: Re: [PATCH] mci: Improve error message for non-existent vmmc regulator
Date: Tue, 14 Sep 2021 13:22:25 +0200 [thread overview]
Message-ID: <72f9df3414bc9c20a2ff5681cf5bd4d775bee8b8.camel@pengutronix.de> (raw)
In-Reply-To: <20210914090017.39627-1-u.kleine-koenig@pengutronix.de>
On Tue, 2021-09-14 at 11:00 +0200, Uwe Kleine-König wrote:
> There are three improvements: a) Use a already initialized device as first
> parameter to dev_err() and b) indicate that the error will be ignored, and
> c) downgrade to a warning.
>
> This changes the error message from
>
> ERROR: <NULL>: Failed to get 'vmmc' regulator.
>
> to
>
> WARNING: bcm2835_mci fe340000.mmc@7e340000.of: Failed to get 'vmmc' regulator (ignored).
>
> on a Raspberry Pi 4.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mci/mci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index 92a73c8f1dfe..82e2f82f5377 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1920,7 +1920,7 @@ int mci_register(struct mci_host *host)
>
> host->supply = regulator_get(hw_dev, "vmmc");
> if (IS_ERR(host->supply)) {
> - dev_err(&mci->dev, "Failed to get 'vmmc' regulator.\n");
> + dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n");
> host->supply = NULL;
> }
>
Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-09-14 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:00 Uwe Kleine-König
2021-09-14 11:22 ` Rouven Czerwinski [this message]
2021-10-02 9:27 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f9df3414bc9c20a2ff5681cf5bd4d775bee8b8.camel@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox