mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* arria10_init_emac() bug?
@ 2017-06-28 15:10 Ian Abbott
  2017-06-30  8:01 ` Steffen Trumtrar
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2017-06-28 15:10 UTC (permalink / raw)
  To: Barebox List; +Cc: Steffen Trumtrar

Hi,

I'm not using Arria-10, but noticed a possible bug in the 
arria10_init_emac() function in 
"arch/arm/mach-socfpga/arria10-generic.c".  The code reads the 
ARRIA10_SYSMGR_FPGAINTF_EN_3 register into a variable, modifies the 
variable value, but doesn't write it back to the register.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: arria10_init_emac() bug?
  2017-06-28 15:10 arria10_init_emac() bug? Ian Abbott
@ 2017-06-30  8:01 ` Steffen Trumtrar
  0 siblings, 0 replies; 2+ messages in thread
From: Steffen Trumtrar @ 2017-06-30  8:01 UTC (permalink / raw)
  To: Ian Abbott; +Cc: Barebox List


Hi,

Ian Abbott <abbotti@mev.co.uk> writes:

> Hi,
>
> I'm not using Arria-10, but noticed a possible bug in the 
> arria10_init_emac() function in 
> "arch/arm/mach-socfpga/arria10-generic.c".  The code reads the 
> ARRIA10_SYSMGR_FPGAINTF_EN_3 register into a variable, modifies the 
> variable value, but doesn't write it back to the register.

Thanks for catching that.
I will send a patch for removing the whole read-modify operation, as it
doesn't do anything now anyway and half of the bits aren't even
mentioned in the datasheet.

Best regards,
Steffen

-- 
Pengutronix e.K.                           | Steffen Trumtrar            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-30  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 15:10 arria10_init_emac() bug? Ian Abbott
2017-06-30  8:01 ` Steffen Trumtrar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox