From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/2] scripts/checkpatch.pl: rebase on top of upstream v5.0-rc6
Date: Tue, 26 Feb 2019 10:55:40 +0100 [thread overview]
Message-ID: <7475eecb-5e8e-a827-f04e-b3d8d749edaf@pengutronix.de> (raw)
In-Reply-To: <20190220101412.5032124aaf26a799c903ec9f@gmail.com>
Hello Antony,
On 20/2/19 08:14, Antony Pavlov wrote:
> On Tue, 19 Feb 2019 15:16:47 +0100
> Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 4e17347a8481..48b39fbf962a 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
> ...
>
>> @@ -1555,13 +2997,9 @@ sub process {
>>
>> my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
>>
>> - # linux device tree files
>> - my $dt_path = $root . "/dts/Bindings/";
>> + my $dt_path = $root . "/Documentation/devicetree/bindings/";
>
> At the moment it looks like barebox uses both paths ("/dts/Bindings/" and "/Documentation/devicetree/bindings/")
> to store dt-related documentation.
Missed this one. I can reinstate it in a v2. I think I should've caught all barebox specifics now.
>
> The patch is very long and very hard to review.
Any suggestion on a better way to do it? It's a straight copy from upstream with
some barebox specific changes applied on top, so I assume ensuring the barebox
changes are accounted for are all the review we need.
I could for v2 include a scripts/checkpatch.patch which patches the corresponding
upstream checkpatch.pl into the barebox checkpatch.pl. That way reviewing would work
like this:
- review checkpatch.patch
- $ patch -R < checkpatch.patch
- $ diff $LINUX/scripts/checkpatch.pl $BAREBOX/scripts/checkpatch.pl
What do you think?
>
> @Sascha
>
> Can we introduce rules on storing dt-documentation?
>
> It looks like we have some dt documentation duplication, e.g.
>
> ./Documentation/devicetree/bindings/rtc/dallas,ds1307.rst
> ./dts/Bindings/rtc/rtc-ds1307.txt
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-26 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 14:16 [PATCH v2 0/2] LICENSES: adopt Linux-like LICENSES directory structure Ahmad Fatoum
2019-02-19 14:16 ` [PATCH v2 1/2] " Ahmad Fatoum
2019-02-22 7:10 ` Sascha Hauer
2019-02-19 14:16 ` [PATCH v2 2/2] scripts/checkpatch.pl: rebase on top of upstream v5.0-rc6 Ahmad Fatoum
2019-02-20 7:14 ` Antony Pavlov
2019-02-20 7:42 ` Sascha Hauer
2019-02-26 9:55 ` Ahmad Fatoum [this message]
2019-03-04 7:26 ` Antony Pavlov
2019-05-15 8:51 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7475eecb-5e8e-a827-f04e-b3d8d749edaf@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox