mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: i.MX: Add support for ZII i.MX8MQ based devices
Date: Mon, 28 Jan 2019 22:05:46 +0100	[thread overview]
Message-ID: <74d4ef0a05b994ae85b83d2206aea431808424aa.camel@pengutronix.de> (raw)
In-Reply-To: <20190126012926.9236-2-andrew.smirnov@gmail.com>

Hi Andrey,

two very high-level comments that you might choose to ignore, but I
want to get them out regardless.

Am Freitag, den 25.01.2019, 17:29 -0800 schrieb Andrey Smirnov:
> Add support for the following ZII i.MX8MQ based boards:
> 
>    - ZII i.MX8MQ RMB3
>    - ZII i.MX8MQ Zest
> 
> Most of the basic peripherals are supported by this patch. More
> advanced features such as PCIe, display support, etc, are planned to
> be added later.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/boards/Makefile                      |   1 +
>  arch/arm/boards/zii-imx8mq-dev/Makefile       |   2 +
>  arch/arm/boards/zii-imx8mq-dev/board.c        |  24 +
>  arch/arm/boards/zii-imx8mq-dev/ddr.h          |  29 +
>  arch/arm/boards/zii-imx8mq-dev/ddr_init.c     | 225 +++++
>  arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c | 935 ++++++++++++++++++
>  .../flash-header-zii-imx8mq-dev.imxcfg        |   5 +
>  arch/arm/boards/zii-imx8mq-dev/lowlevel.c     | 211 ++++

Why is the directory called -dev? I expect that we will support the
final production versions with the same code, so I would drop this
suffix.

>  arch/arm/dts/Makefile                         |   3 +
>  arch/arm/dts/imx8mq-zii-ultra-rmb3.dts        |  39 +
>  arch/arm/dts/imx8mq-zii-ultra-zest.dts        |  13 +
>  arch/arm/dts/imx8mq-zii-ultra.dtsi            | 453 +++++++++

Somewhat along the same lines, I not really sure if we should use
marketing names for the DTs. My experience from other projects is that
it's much easier to use internal names like RDU3 if you care about
stable names, as marketing people seem to like to rename stuff after
the fact.

Regards,
Lucas

>  arch/arm/mach-imx/Kconfig                     |   7 +
>  images/Makefile.imx                           |   5 +
>  14 files changed, 1952 insertions(+)
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/Makefile
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/board.c
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/ddr.h
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/ddr_init.c
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/ddrphy_train.c
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/flash-header-zii-imx8mq-dev.imxcfg
>  create mode 100644 arch/arm/boards/zii-imx8mq-dev/lowlevel.c
>  create mode 100644 arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
>  create mode 100644 arch/arm/dts/imx8mq-zii-ultra-zest.dts
>  create mode 100644 arch/arm/dts/imx8mq-zii-ultra.dtsi



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-01-28 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26  1:29 [PATCH 1/2] ARM: i.MX8MQ: bbu: Add MMC boot handler Andrey Smirnov
2019-01-26  1:29 ` [PATCH 2/2] ARM: i.MX: Add support for ZII i.MX8MQ based devices Andrey Smirnov
2019-01-26  1:49   ` Andrey Smirnov
2019-01-28 21:05   ` Lucas Stach [this message]
2019-01-29  1:41     ` Andrey Smirnov
2019-01-29  1:49       ` Chris Healy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74d4ef0a05b994ae85b83d2206aea431808424aa.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox