From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Yunus Bas <y.bas@phytec.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: pfla02: Update spi-nor naming for kernel compatibility
Date: Mon, 3 May 2021 14:38:56 +0200 [thread overview]
Message-ID: <764115d0-c22e-8c22-4533-1a11e48d3748@pengutronix.de> (raw)
In-Reply-To: <20210503122550.2951035-1-y.bas@phytec.de>
Hello Yunus,
On 03.05.21 14:25, Yunus Bas wrote:
> The kernel NVMEM-subsystem prevents the usage of duplicate partition names.
> Change the SPI-NOR partition names to be compatible with the kernel
> driver.
I don't mind the change, but I can't follow the reasoning.
These are MTD partitions, so they shouldn't have been registered with the NVMEM
framework in the first place?
Cheers,
Ahmad
>
> Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for
> compatibility with kernel") applies the change for phyCORE SOMs. The
> same applies for phyFLEX-modules.
>
> Signed-off-by: Yunus Bas <y.bas@phytec.de>
> ---
> arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index e1aa3183b..6df8d247b 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -21,7 +21,7 @@
>
> environment-spinor {
> compatible = "barebox,environment";
> - device-path = &som_flash, "partname:barebox-environment";
> + device-path = &som_flash, "partname:nor.barebox-environment";
> status = "disabled";
> };
>
> @@ -54,28 +54,29 @@
> /delete-node/ &{/memory@10000000};
>
> &som_flash {
> +
> partitions {
> compatible = "fixed-partitions";
> #address-cells = <1>;
> #size-cells = <1>;
>
> partition@0 {
> - label = "barebox";
> + label = "nor.barebox";
> reg = <0x0 0x100000>;
> };
>
> partition@100000 {
> - label = "barebox-environment";
> + label = "nor.barebox-environment";
> reg = <0x100000 0x20000>;
> };
>
> partition@120000 {
> - label = "oftree";
> + label = "nor.oftree";
> reg = <0x120000 0x20000>;
> };
>
> partition@140000 {
> - label = "kernel";
> + label = "nor.kernel";
> reg = <0x140000 0x0>;
> };
> };
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-05-03 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 12:25 Yunus Bas
2021-05-03 12:38 ` Ahmad Fatoum [this message]
2021-05-03 14:38 ` Yunus Bas
2021-05-03 18:36 ` Ahmad Fatoum
2021-05-03 21:50 ` Yunus Bas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764115d0-c22e-8c22-4533-1a11e48d3748@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=y.bas@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox