Re: [PATCH 4/5] ARM: novena: Read Ethernet MAC address from EEPROM

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 25.01.23 15:04, John Watts wrote:
> On Wed, Jan 25, 2023 at 02:48:20PM +0100, Ahmad Fatoum wrote:
>> regulator-fixed only understands vin-supply.
> 
> Right, changed. I was under the assumption that ANY node could specify an
> X-supply.

vin-supply is handled by regulator core. Other X-supply needs to be
explicitly requested by driver.

>> I actually updated the eeprom node to use
>>> reg_3p3v as vcc-supply and things were still probed in the wrong order.
>>
>> That's odd. You can enable CONFIG_DEBUG_PROBES to see in what order
>> probes happened and at what depth (each probe within a probe is
>> indented more than its parent).
> 
> Should that even work? The vcc-supply property isn't a real one.

It does in Linux :-)

We could add the binding to the barebox AT24/AT25 driver. We'll need
to make sure we don't fail the probe in the error path as not to
break existing users. Fortunately, with deep probe, we will
have no -EPROBE_DEFER that would complicate this.

> 
> Currently the probe log is this:
> 
> detected i.MX6 Quad revision 1.2
> i.MX6 Quad unique ID: c1d99d4d8191854
>     probe-> 21e8000.serial@21e8000.of
>         probe-> 20e0000.pinctrl@20e0000.of
>     probe-> 21b0000.memory-controller@21b0000.of
>     probe-> ramfs0
>     probe-> devfs0
>     probe-> mem0
>     probe-> mem1
> netconsole: port not set
> netconsole: registered as netconsole-1
>     probe-> machine
>         probe-> 21a8000.i2c@21a8000.of
>             probe-> 24c5120
> Unable to read Novena EEPROM: Connection timed out
>     probe-> ldb.of
> imx-ldb ldb.of: Neither display timings in ldb node nor remote panel found
> imx-ldb ldb.of: dual-channel mode, ignoring second output
>     probe-> usbphynop1.of
>     probe-> usbphynop2.of
>     probe-> 110000.dma-apbh@110000.of
>     probe-> 120000.hdmi@120000.of
> imx-hdmi 120000.hdmi@120000.of: Detected HDMI controller 0x13:0xa:0xa0:0xc1
>     probe-> 2010000.spi@2010000.of
>     probe-> 2080000.pwm@2080000.of
>     probe-> 209c000.gpio@209c000.of
>     probe-> 20a0000.gpio@20a0000.of
>     probe-> 20a4000.gpio@20a4000.of
>     probe-> 20a8000.gpio@20a8000.of
>     probe-> 20ac000.gpio@20ac000.of
>     probe-> 20b0000.gpio@20b0000.of
>     probe-> 20b4000.gpio@20b4000.of
>     probe-> 20bc000.watchdog@20bc000.of
>     probe-> 20c9000.usbphy@20c9000.of
>     probe-> 20ca000.usbphy@20ca000.of
>     probe-> 20d8000.reset-controller@20d8000.of
>     probe-> 2184000.usb@2184000.of
>         probe-> 2184800.usbmisc@2184800.of
>         probe-> regulator-usb-otg-vbus.of
>     probe-> 2184200.usb@2184200.of
>         probe-> 21a4000.i2c@21a4000.of
>             probe-> pfuze1000
> imx-usb 2184200.usb@2184200.of: Cannot get vbus regulator: No such device (ignoring)
> imx-usb 2184200.usb@2184200.of: USB EHCI 1.00
>     probe-> 2188000.ethernet@2188000.of
> mdio_bus: miibus0: probed
>     probe-> 2194000.mmc@2194000.of
> imx-esdhc 2194000.mmc@2194000.of: registered as mmc1
>     probe-> 2198000.mmc@2198000.of
> imx-esdhc 2198000.mmc@2198000.of: registered as mmc2
>     probe-> 21a0000.i2c@21a0000.of
>     probe-> 21bc000.efuse@21bc000.of
>     probe-> 21ec000.serial@21ec000.of
>     probe-> 21f0000.serial@21f0000.of
>     probe-> 2400000.ipu@2400000.of
> imx-ipuv3 2400000.ipu@2400000.of: IPUv3H probed
>     probe-> 2200000.sata@2200000.of
>     probe-> 2800000.ipu@2800000.of
> imx-ipuv3 2800000.ipu@2800000.of: IPUv3H probed
>     probe-> gpio-keys.of
>     probe-> leds.of
>     probe-> regulator-2p5v.of
>     probe-> regulator-3p3v.of
>     probe-> regulator-5p0v.of
>     probe-> regulator-audio-codec.of
>     probe-> regulator-display.of
>     probe-> regulator-lvds-lcd.of
>     probe-> regulator-pcie.of
>     probe-> regulator-sata.of
> malloc space: 0xbfcf55c0 -> 0xffcf55bf (size 1 GiB)
>     probe-> imx-ipuv3-crtc0
>     probe-> imx-ipuv3-crtc1
>     probe-> imx-ipuv3-crtc2
>     probe-> imx-ipuv3-crtc3
> 
>>
>> Cheers,
>> Ahmad
> 
> John.
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |