From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: mmu_32: fix setting up zero page when it is in SDRAM
Date: Wed, 31 May 2023 12:10:22 +0200 [thread overview]
Message-ID: <7936b29e-2a89-570e-bb90-43f215999438@pengutronix.de> (raw)
In-Reply-To: <20230531100128.819492-2-s.hauer@pengutronix.de>
Hello Sascha,
On 31.05.23 12:01, Sascha Hauer wrote:
> We used to skip setting the zero page to faulting when SDRAM starts
> at 0x0. As bootm code now explicitly sets the zero page accessible
> before copying ATAGs there this should no longer be necessary, so
> unconditionally set the zero page to faulting during MMU startup.
> This also moves the zero page setup after the point the SDRAM has
> been mapped cachable, because otherwise the zero page setup would
> be overwritten.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/cpu/mmu_32.c | 21 ++-------------------
> 1 file changed, 2 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/cpu/mmu_32.c b/arch/arm/cpu/mmu_32.c
> index c4e5a3bb0a..faebba42d0 100644
> --- a/arch/arm/cpu/mmu_32.c
> +++ b/arch/arm/cpu/mmu_32.c
> @@ -459,23 +459,6 @@ static int set_vector_table(unsigned long adr)
> return -EINVAL;
> }
>
> -static void create_zero_page(void)
> -{
> - struct resource *zero_sdram;
> -
> - zero_sdram = request_sdram_region("zero page", 0x0, PAGE_SIZE);
I think this should remain to avoid some $platform overwriting ATAGS
or w/e with the kernel image. I know this is a discrepancy to ARM64,
but let's play it safe?
> - if (zero_sdram) {
> - /*
> - * Here we would need to set the second level page table
> - * entry to faulting. This is not yet implemented.
> - */
> - pr_debug("zero page is in SDRAM area, currently not supported\n");
> - } else {
> - zero_page_faulting();
> - pr_debug("Created zero page\n");
> - }
> -}
> -
> /*
> * Map vectors and zero page
> */
> @@ -487,7 +470,6 @@ static void vectors_init(void)
> */
> if (!set_vector_table((unsigned long)__exceptions_start)) {
> arm_fixup_vectors();
> - create_zero_page();
> return;
> }
>
> @@ -495,7 +477,6 @@ static void vectors_init(void)
> * Next try high vectors at 0xffff0000.
> */
> if (!set_vector_table(ARM_HIGH_VECTORS)) {
> - create_zero_page();
> create_vector_table(ARM_HIGH_VECTORS);
> return;
> }
> @@ -552,6 +533,8 @@ void __mmu_init(bool mmu_on)
>
> remap_range((void *)pos, bank->start + bank->size - pos, MAP_CACHED);
> }
> +
> + zero_page_faulting();
> }
>
> /*
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-31 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 10:01 [PATCH 1/2] ARM: set zero page accessible before copying ATAGs there Sascha Hauer
2023-05-31 10:01 ` [PATCH 2/2] ARM: mmu_32: fix setting up zero page when it is in SDRAM Sascha Hauer
2023-05-31 10:10 ` Ahmad Fatoum [this message]
2023-05-31 10:08 ` [PATCH 1/2] ARM: set zero page accessible before copying ATAGs there Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7936b29e-2a89-570e-bb90-43f215999438@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox