From: Frank Wunderlich <frank-w@public-files.de>
To: Sascha Hauer <sha@pengutronix.de>,Frank Wunderlich <linux@fw-web.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: Rockchip: rk3568: add tsadc and spi
Date: Fri, 11 Feb 2022 12:14:56 +0100 [thread overview]
Message-ID: <7F60960B-A04B-4B82-BB44-43EC6EC7DCD1@public-files.de> (raw)
In-Reply-To: <20220211104344.GG18637@pengutronix.de>
Am 11. Februar 2022 11:43:44 MEZ schrieb Sascha Hauer <sha@pengutronix.de>:
>Hi Frank,
>
>On Fri, Feb 11, 2022 at 10:11:14AM +0100, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Add tsadc and spi node from linux.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>> arch/arm/dts/rk3568-pinctrl.dtsi | 9 ++++++++
>> arch/arm/dts/rk3568.dtsi | 35
>++++++++++++++++++++++++++++++++
>> 2 files changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi
>b/arch/arm/dts/rk3568-pinctrl.dtsi
>> index a588ca95ace2..8f90c66dd9e9 100644
>> --- a/arch/arm/dts/rk3568-pinctrl.dtsi
>> +++ b/arch/arm/dts/rk3568-pinctrl.dtsi
>> @@ -3108,4 +3108,13 @@
>> <4 RK_PA0 3 &pcfg_pull_none_drv_level_2>;
>> };
>> };
>> +
>> + tsadc {
>> + /omit-if-no-ref/
>> + tsadc_pin: tsadc-pin {
>> + rockchip,pins =
>> + /* tsadc_pin */
>> + <0 RK_PA1 0 &pcfg_pull_none>;
>> + };
>> + };
>> };
>> diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
>> index 0f19d3f0c0c3..6afd95b01c0c 100644
>> --- a/arch/arm/dts/rk3568.dtsi
>> +++ b/arch/arm/dts/rk3568.dtsi
>> @@ -772,6 +772,21 @@
>> clock-names = "tclk", "pclk";
>> };
>>
>> + spi3: spi@fe640000 {
>> + compatible = "rockchip,rk3568-spi", "rockchip,rk3066-spi";
>> + reg = <0x0 0xfe640000 0x0 0x1000>;
>> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
>> + clock-names = "spiclk", "apb_pclk";
>> + dmas = <&dmac0 26>, <&dmac0 27>;
>> + dma-names = "tx", "rx";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&spi3m0_cs0 &spi3m0_cs1 &spi3m0_pins>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>> + };
>
>When you asked me if you should keep tsadc/spi3 in your board dts I
>didn't understand that these are missing in rk3568.dtsi.
>Adding these nodes when barebox doesn't use them has no gain for us. I
>won't take this patch and removed references to spi3/tsadc from your
>board patch while applying.
>
>Sascha
Hi,
I understood it,that when you take the mainline-linux dts it will not find spi3 and tsadc in rk3568.dtsi. Or do you plan to sync this too?
regards Frank
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-02-11 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 9:11 Frank Wunderlich
2022-02-11 10:43 ` Sascha Hauer
2022-02-11 11:14 ` Frank Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F60960B-A04B-4B82-BB44-43EC6EC7DCD1@public-files.de \
--to=frank-w@public-files.de \
--cc=barebox@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox