From: Marc Kleine-Budde <mkl@pengutronix.de>
To: barebox@lists.infradead.org
Subject: bootm_open_initrd_uimage: result of uimage_verify() is ignored
Date: Mon, 18 Sep 2017 21:33:01 +0200 [thread overview]
Message-ID: <7ca89d8a-f413-3728-1990-40802e5cb2b6@pengutronix.de> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 1043 bytes --]
Hello,
the bootm_open_initrd_uimage() function will check the CRC of the inird,
if bootm_get_verify_mode is set appropriately, but the error value is
not propagated.
> static int bootm_open_initrd_uimage(struct image_data *data)
> {
> int ret;
>
> if (strcmp(data->os_file, data->initrd_file)) {
> data->initrd = uimage_open(data->initrd_file);
> if (!data->initrd)
> return -EINVAL;
>
> if (bootm_get_verify_mode() > BOOTM_VERIFY_NONE) {
> ret = uimage_verify(data->initrd);
> if (ret) {
> printf("Checking data crc failed with %s\n",
> strerror(-ret));
> }
> }
> uimage_print_contents(data->initrd);
> } else {
> data->initrd = data->os;
> }
>
> return 0;
> }
Is this intentional?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2017-09-18 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 19:33 Marc Kleine-Budde [this message]
2017-09-19 6:44 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca89d8a-f413-3728-1990-40802e5cb2b6@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox