bootm_open_initrd_uimage: result of uimage_verify() is ignored

bootm_open_initrd_uimage: result of uimage_verify() is ignored

[Marc Kleine-Budde]

[-- Attachment #1.1.1: Type: text/plain, Size: 1043 bytes --]

Hello,

the bootm_open_initrd_uimage() function will check the CRC of the inird,
if bootm_get_verify_mode is set appropriately, but the error value is
not propagated.

> static int bootm_open_initrd_uimage(struct image_data *data)
> {
> 	int ret;
> 
> 	if (strcmp(data->os_file, data->initrd_file)) {
> 		data->initrd = uimage_open(data->initrd_file);
> 		if (!data->initrd)
> 			return -EINVAL;
> 
> 		if (bootm_get_verify_mode() > BOOTM_VERIFY_NONE) {
> 			ret = uimage_verify(data->initrd);
> 			if (ret) {
> 				printf("Checking data crc failed with %s\n",
> 					strerror(-ret));
> 			}
> 		}
> 		uimage_print_contents(data->initrd);
> 	} else {
> 		data->initrd = data->os;
> 	}
> 
> 	return 0;
> }

Is this intentional?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: bootm_open_initrd_uimage: result of uimage_verify() is ignored

[Sascha Hauer]

On Mon, Sep 18, 2017 at 09:33:01PM +0200, Marc Kleine-Budde wrote:
> Hello,
> 
> the bootm_open_initrd_uimage() function will check the CRC of the inird,
> if bootm_get_verify_mode is set appropriately, but the error value is
> not propagated.
> 
> > static int bootm_open_initrd_uimage(struct image_data *data)
> > {
> > 	int ret;
> > 
> > 	if (strcmp(data->os_file, data->initrd_file)) {
> > 		data->initrd = uimage_open(data->initrd_file);
> > 		if (!data->initrd)
> > 			return -EINVAL;
> > 
> > 		if (bootm_get_verify_mode() > BOOTM_VERIFY_NONE) {
> > 			ret = uimage_verify(data->initrd);
> > 			if (ret) {
> > 				printf("Checking data crc failed with %s\n",
> > 					strerror(-ret));
> > 			}
> > 		}
> > 		uimage_print_contents(data->initrd);
> > 	} else {
> > 		data->initrd = data->os;
> > 	}
> > 
> > 	return 0;
> > }
> 
> Is this intentional?

I suppose not :(

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox