mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: robin <robin@protonic.nl>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] i.MX: HABv4: Improve HAB event printing
Date: Tue, 24 Nov 2020 08:57:30 +0100	[thread overview]
Message-ID: <7cc581eb0bfbabe3d8d4d0213d4beebc@protonic.nl> (raw)
In-Reply-To: <20201123163805.11164-1-s.hauer@pengutronix.de>

Hi Sascha,

On 2020-11-23 17:38, Sascha Hauer wrote:
> Instead of using a fixed sized buffer for the report_event function,
> let's call it two times, once with a NULL pointer to get the size of 
> the
> event and a second time with a buffer of that size.
> Also, instead of separating the events into warning and error type,
> iterate over all events in one single loop. This helps to get the 
> events
> in the order they occured which probably helps the reader to make more
> sense of them.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Even better!

Is it worth mentioning that this also fixes the unjustified
'Recompile with larger event data buffer' error?

Acked-by: Robin van der Gracht

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-11-24  7:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 16:38 Sascha Hauer
2020-11-24  7:57 ` robin [this message]
2020-11-24  8:32   ` robin
2020-11-24  9:12     ` Sascha Hauer
2020-11-24  9:34       ` robin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cc581eb0bfbabe3d8d4d0213d4beebc@protonic.nl \
    --to=robin@protonic.nl \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox