From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from protonic.xs4all.nl ([83.163.252.89]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTCj-0007Tq-Dr for barebox@lists.infradead.org; Tue, 24 Nov 2020 07:57:38 +0000 MIME-Version: 1.0 Date: Tue, 24 Nov 2020 08:57:30 +0100 From: robin In-Reply-To: <20201123163805.11164-1-s.hauer@pengutronix.de> References: <20201123163805.11164-1-s.hauer@pengutronix.de> Message-ID: <7cc581eb0bfbabe3d8d4d0213d4beebc@protonic.nl> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: robin@protonic.nl Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] i.MX: HABv4: Improve HAB event printing To: Sascha Hauer Cc: Barebox List Hi Sascha, On 2020-11-23 17:38, Sascha Hauer wrote: > Instead of using a fixed sized buffer for the report_event function, > let's call it two times, once with a NULL pointer to get the size of > the > event and a second time with a buffer of that size. > Also, instead of separating the events into warning and error type, > iterate over all events in one single loop. This helps to get the > events > in the order they occured which probably helps the reader to make more > sense of them. > > Signed-off-by: Sascha Hauer Even better! Is it worth mentioning that this also fixes the unjustified 'Recompile with larger event data buffer' error? Acked-by: Robin van der Gracht _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox