From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 Mar 2025 12:46:11 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1try3o-00Cf1O-1R for lore@lore.pengutronix.de; Tue, 11 Mar 2025 12:46:11 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1try3n-0005xS-6V for lore@pengutronix.de; Tue, 11 Mar 2025 12:46:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tdMbF6V49uGl6+PQ+Q4mOVQC+a/IbUWoPpzs8yN+WoI=; b=VBS+ZFWmaFe7ArhbBLIBmQ4qKi H1VdKyreyyNBrl/o45U9St5mYnv6dRUA1A/KPIe20axAYdu+FPGC5XIj8PcadhiYqqjAgb6dHfB9G PKtLSpVPs0BCDw9QusO65hNIQcnEM0DtUrJUfneVQ8XZjVS6lfjEMqtvr0mrVEm5CFc6VOdfcj3d1 i5pcyxhp0KvUo5V9jOW7qVLPvF0t+Wl3lT3S00fyoABo6eStjgeZwrklJfd1M0z+F3p8zurFI7Vwj QKS0n5ZDcicS/pnpEXFNv3jzj6iFwSQS54ngd/+Swu6PjZw6s+Y/Lcv2VorXor6QWY6sVWShnnHyC V6RdADxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1try3L-00000005WGD-1DY6; Tue, 11 Mar 2025 11:45:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1try0P-00000005VfX-48Gi for barebox@lists.infradead.org; Tue, 11 Mar 2025 11:42:43 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1try0O-0005Pf-P3; Tue, 11 Mar 2025 12:42:40 +0100 Message-ID: <7e01458c-d25f-4f74-a864-a85fe86c02f3@pengutronix.de> Date: Tue, 11 Mar 2025 12:42:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jonas Rebmann , Sascha Hauer , BAREBOX References: <20250311-pca9450-wdog-v1-0-45120abeae00@pengutronix.de> <20250311-pca9450-wdog-v1-2-45120abeae00@pengutronix.de> <2a97c0f8-f9fd-47f0-8ac6-a0c5b7499dc1@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: <2a97c0f8-f9fd-47f0-8ac6-a0c5b7499dc1@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250311_044242_020941_F3B0BB9F X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/2] ARM: boards: remove obsolete PCA9450_RESET_CTRL setup X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Jonas, On 3/11/25 12:21, Jonas Rebmann wrote: > Hi Ahmad, > > Not so much. As mentioned in the cover, the imx8 boards routinely > configure a larger array of pca9450 registers. As I didn't give the rest > of that setup a closer look, I did not change the code. Ah, should've read the cover letter, my bad. Please add that information into the commit messages, so it becomes part of the git history. > I have only tested this series on the phyboard segin imx93. > > Just like with the imx93 boards, after application of the driver patch, > the { PCA9450_RESET_CTRL, 0xA1 } lines in lowlevel.c should no more have > an effect (as no board currently uses nxp,wdog_b-warm-reset). > > Should I remove all { PCA9450_RESET_CTRL, 0xA1 } configuration in v2? An explanation in the commit message why this wasn't done is enough. Cheers, Ahmad > >  - Jonas > > On 2025-03-11 12:03, Ahmad Fatoum wrote: >> Hi, >> >> On 3/11/25 11:50, Jonas Rebmann wrote: >>> Since a previous commit, PCA9450_RESET_CTRL is initialized to 0xA1 in >>> pca9450_probe; explicitly setting this in board.c has no effect anymore. >> >> Note that there is a number of i.MX8M boards that also use the PCA9450 >> and configure 0xA1 into PCA9450_RESET_CTRL in their lowlevel.c. >> >> Any particular reason against or for dropping the configuration there? >> >> Thanks, >> Ahmad >> >>> Signed-off-by: Jonas Rebmann >>> --- >>>   arch/arm/boards/phytec-phycore-imx93/board.c | 9 --------- >>>   arch/arm/boards/tqma93xx/board.c             | 3 --- >>>   2 files changed, 12 deletions(-) >>> >>> diff --git a/arch/arm/boards/phytec-phycore-imx93/board.c b/arch/arm/ >>> boards/phytec-phycore-imx93/board.c >>> index >>> 149248ca654624826d0e8f6fe0f1f42c2747e248..03ba8cb5026d2a9eaa054fcfc69e18872fcd658e 100644 >>> --- a/arch/arm/boards/phytec-phycore-imx93/board.c >>> +++ b/arch/arm/boards/phytec-phycore-imx93/board.c >>> @@ -6,23 +6,14 @@ >>>   #include >>>   #include >>>   #include >>> -#include >>>   #include >>>   #include >>>   #include >>>   -static void phycore_imx93_init_pmic(struct regmap *map) >>> -{ >>> -    /* set WDOG_B_CFG to cold reset */ >>> -    regmap_write(map, PCA9450_RESET_CTRL, 0xA1); >>> -} >>> - >>>   static int phycore_imx93_probe(struct device *dev) >>>   { >>>       struct device_node *np; >>>   -    pca9450_register_init_callback(phycore_imx93_init_pmic); >>> - >>>       /* >>>        * The phy on the EQOS has its MDIO lines connected to the FEC. >>> The phy >>>        * registers can only be successfully read when the EQOS >>> pinctrl setup >>> diff --git a/arch/arm/boards/tqma93xx/board.c b/arch/arm/boards/ >>> tqma93xx/board.c >>> index >>> b181784079cf12e5a112d13f95c87c2cf5ebeba6..b4de6c2f6c347cb255537a3784a667a9c2607de3 100644 >>> --- a/arch/arm/boards/tqma93xx/board.c >>> +++ b/arch/arm/boards/tqma93xx/board.c >>> @@ -27,9 +27,6 @@ static void tqma93xx_init_pmic(struct regmap *map) >>>         /* I2C_LT_EN*/ >>>       regmap_write(map, 0xa, 0x3); >>> - >>> -    /* set WDOG_B_CFG to cold reset */ >>> -    regmap_write(map, PCA9450_RESET_CTRL, 0xA1); >>>   } >>>     static int tqma93xx_probe(struct device *dev) >>> >> >> >> > >