From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Fabian Pfitzner <f.pfitzner@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX: karo-tx6: use mmcboot handler
Date: Tue, 21 Oct 2025 17:28:30 +0200 [thread overview]
Message-ID: <81684845-be3f-462e-8e4f-7d420d91e241@pengutronix.de> (raw)
In-Reply-To: <20251021144106.1228193-2-f.pfitzner@pengutronix.de>
On 10/21/25 4:41 PM, Fabian Pfitzner wrote:
> Use the mmcboot handler instead. This handler automatically determines
> the boot partition by considering the partition's state, thus avoiding
> to specify it manually.
>
> Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
I think this is worth an entry in the migration guide. See the fixup I
just sent. I think Sascha can squash it if there are no other comments.
Cheers,
Ahmad
> ---
> arch/arm/boards/karo-tx6x/board.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/karo-tx6x/board.c b/arch/arm/boards/karo-tx6x/board.c
> index f3ff59afb9..43e23f00cd 100644
> --- a/arch/arm/boards/karo-tx6x/board.c
> +++ b/arch/arm/boards/karo-tx6x/board.c
> @@ -115,7 +115,7 @@ static int tx6x_devices_init(void)
> of_device_enable_and_register_by_name("environment-nand");
> of_device_enable_and_register_by_alias("nand");
> } else {
> - imx6_bbu_internal_mmc_register_handler("eMMC", "/dev/mmc3.boot0",
> + imx6_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc3",
> BBU_HANDLER_FLAG_DEFAULT);
> of_device_enable_and_register_by_name("environment-emmc");
> of_device_enable_and_register_by_alias("mmc3");
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-10-21 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 14:41 Fabian Pfitzner
2025-10-21 15:27 ` [PATCH] fixup! " Ahmad Fatoum
2025-10-21 15:28 ` Ahmad Fatoum [this message]
2025-10-22 6:30 ` [PATCH] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81684845-be3f-462e-8e4f-7d420d91e241@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=f.pfitzner@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox