Re: [PATCH] common: fastboot: send FAIL if variable does not exist

[Andrei Lalaev <andrey.lalaev@gmail.com>]

On 22.07.2025 16:07, Ahmad Fatoum wrote:
> Hello Andrei,
> 
> On 6/11/25 19:56, Andrei Lalaev wrote:
>> According to doc [1], new implementations should send FAIL if the
>> variable specified in the getvar command does not exist.
>>
>> [1]: https://android.googlesource.com/platform/system/core/+show/refs/heads/main/fastboot/README.md#121
>>
>> Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com>
> 
> Did you run into any particular issues that motivated your change?

Hi Ahmad,

Sorry, I should have written a more descriptive commit message
or at least mentioned the root cause in the footer.

I was using uuu v1.5.201 with barebox 2025.01 (or 2025.02) to flash
a raw image to eMMC using the raw2flash flag. Unfortunately,
due to a bug in uuu, it ended up flashing garbage :/
I’ve fixed the issue in uuu [1], but during the investigation
I found out that newer implementation of Fastboot should send FAIL
if variable is missing, so I also decided to send a patch to barebox.

1 - https://github.com/nxp-imx/mfgtools/commit/f7351c1cf626764d902576362421f33b79b3a9e9

> 
> Thanks,
> Ahmad
> 

-- 
Best regards,
Andrei Lalaev