mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH][RFC] lib: zstd: resolve maybe-uninitialized warning
@ 2023-06-14  8:09 yegorslists
  2023-06-14  8:10 ` Yegor Yefremov
  2023-06-14  8:55 ` Ahmad Fatoum
  0 siblings, 2 replies; 5+ messages in thread
From: yegorslists @ 2023-06-14  8:09 UTC (permalink / raw)
  To: barebox

From: Yegor Yefremov <yegorslists@googlemail.com>

Perform memset() at the very beginning of the ZSTD_getFrameParams()
routine.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 lib/zstd/decompress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/zstd/decompress.c b/lib/zstd/decompress.c
index 19bf712881..78df7d660a 100644
--- a/lib/zstd/decompress.c
+++ b/lib/zstd/decompress.c
@@ -207,6 +207,7 @@ static size_t ZSTD_frameHeaderSize(const void *src, size_t srcSize)
 size_t ZSTD_getFrameParams(ZSTD_frameParams *fparamsPtr, const void *src, size_t srcSize)
 {
 	const BYTE *ip = (const BYTE *)src;
+	memset(fparamsPtr, 0, sizeof(*fparamsPtr));
 
 	if (srcSize < ZSTD_frameHeaderSize_prefix)
 		return ZSTD_frameHeaderSize_prefix;
@@ -214,7 +215,6 @@ size_t ZSTD_getFrameParams(ZSTD_frameParams *fparamsPtr, const void *src, size_t
 		if ((ZSTD_readLE32(src) & 0xFFFFFFF0U) == ZSTD_MAGIC_SKIPPABLE_START) {
 			if (srcSize < ZSTD_skippableHeaderSize)
 				return ZSTD_skippableHeaderSize; /* magic number + skippable frame length */
-			memset(fparamsPtr, 0, sizeof(*fparamsPtr));
 			fparamsPtr->frameContentSize = ZSTD_readLE32((const char *)src + 4);
 			fparamsPtr->windowSize = 0; /* windowSize==0 means a frame is skippable */
 			return 0;
-- 
2.34.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-14  9:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14  8:09 [PATCH][RFC] lib: zstd: resolve maybe-uninitialized warning yegorslists
2023-06-14  8:10 ` Yegor Yefremov
2023-06-14  8:55 ` Ahmad Fatoum
2023-06-14  9:11   ` Yegor Yefremov
2023-06-14  9:16     ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox