mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: buildroot@buildroot.org,  barebox@lists.infradead.org
Subject: Re: [PATCH] boot/barebox: install all barebox images if none were specified
Date: Sun, 25 Feb 2024 08:48:53 +0100	[thread overview]
Message-ID: <871q91t256.fsf@48ers.dk> (raw)
In-Reply-To: <20240219210628.407423-1-a.fatoum@pengutronix.de> (Ahmad Fatoum's message of "Mon, 19 Feb 2024 22:06:28 +0100")

>>>>> "Ahmad" == Ahmad Fatoum <a.fatoum@pengutronix.de> writes:

 > When selecting barebox in menuconfig, BR2_TARGET_BAREBOX_IMAGE_FILE will
 > be empty by default, which causes Buildroot to install whatever the
 > barebox-flash-image symlink points at for barebox versions >= v2012.10.0.

 > This is an outdated fallback, because barebox-flash-image is only valid
 > when the barebox build produces a single binary. Virtually all new
 > defconfigs added in the last couple of years are multiconfig
 > (CONFIG_PBL_IMAGE=y) however, meaning that a single imx_v7_defconfig
 > or multi_v8_defconfig will produce many images that support different
 > boards or even platforms.

 > As there is no single valid target for barebox-flash-image to point at
 > in this case, this symlink will point at a non-existing
 > 'multi-image-build' to alert the user to this fact.

 > As replacement for barebox-flash-image, barebox commit 550cf79c216a
 > ("Make list of flash images and fix link all single image cases") first
 > released with v2015.12.0 creates a barebox-flash-images file with a list
 > of all images built by barebox.

 > Have buildroot use that file as a fallback before trying
 > barebox-flash-image to have a fallback that works for any recent barebox
 > defconfig as well.

 > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard



      reply	other threads:[~2024-02-25  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 21:06 Ahmad Fatoum
2024-02-25  7:48 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q91t256.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox